[codex] Apply audit remediation#45
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd1a2ba5cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| report = check_internal_dependency_matrix.check_matrix( | ||
| matrix_pins=matrix_pins, | ||
| projects_root=ROOT.parent, | ||
| ) |
There was a problem hiding this comment.
This test assumes every matrix consumer repo exists next to this checkout via ROOT.parent, but the updated validate workflow only checks out this repository before running python3 -m unittest discover -s tests -v, so a normal GitHub Actions run has no BinancePlatform, LongBridgePlatform, etc. siblings. In that context the test fails with all matrix paths in missing_files (reproducible in a clean checkout), blocking every push/PR unless those external repos are manually present.
Useful? React with 👍 / 👎.
Pigbibi
force-pushed
the
codex/report-remediation-20260610
branch
from
dd1a2ba to
a57b863
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a57b8634a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const response = await fetchWithTimeout(`https://api.github.com/user/orgs?per_page=100&page=${page}`, { | ||
| headers: githubHeaders(token), | ||
| }); |
There was a problem hiding this comment.
When GitHub's org-membership endpoint is slow, this new timeout throws out of fetchGithubOrgLogins, and finishLogin awaits it before checking allowed_logins/admin_logins, so even users authorized explicitly by login get a 500 instead of a session. The function already treats non-OK org responses as non-fatal by returning the orgs collected so far; catch timeout/fetch errors here the same way so org lookup failures only affect org-based authorization.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
git diff --checkpassed across the remediation scopeSee local audit report:
QuantStrategyLab-review-2026-06-10.md.