Skip to content

Clarify dynamic volatility context in Telegram signals#114

Merged
Pigbibi merged 1 commit into
mainfrom
telegram-dynamic-volatility-context-20260610
Jun 9, 2026
Merged

Clarify dynamic volatility context in Telegram signals#114
Pigbibi merged 1 commit into
mainfrom
telegram-dynamic-volatility-context-20260610

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • emit SOXL volatility delever reasons with an explicit effective threshold detail
  • include dynamic percentile/lookback/floor-cap/sample context when rolling thresholds are active
  • keep the legacy trigger code and fallback text for backward compatibility

Verification

  • python -m py_compile src/us_equity_strategies/strategies/soxl_soxx_trend_income.py
  • python -m pytest tests/test_strategy_plans.py -q -k dynamic_volatility_delever (skipped locally because numpy/pandas are not installed on the VPS)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15fa8519e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

_translate_with_fallback(
translator,
"blend_gate_reason_volatility_delever",
"blend_gate_reason_volatility_delever_dynamic",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the fixed volatility-delever reason key for fixed mode

When callers leave blend_gate_volatility_delever_threshold_mode at its default fixed, this still emits the new blend_gate_reason_volatility_delever_dynamic reason key. With the repo's default translator or any existing catalog that only knows the previous fixed reason key, the Telegram/diagnostic reason is mislabeled as dynamic even though the threshold detail says it is fixed; choose the dynamic key only for rolling-percentile mode, or keep a generic/fixed key for the fixed path.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 14d97f0 into main Jun 9, 2026
1 check passed
@Pigbibi Pigbibi deleted the telegram-dynamic-volatility-context-20260610 branch June 9, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant