BSP/qomu: fix qomu_hardwaresetup declaration#137
Open
trabucayre wants to merge 1 commit into
Open
Conversation
Author
|
ping ? |
Collaborator
|
@trabucayre Yes you are right, we will work on fixing this as part of adding new applications to qomu shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a inconsistency between function declaration (BSP/inc/qomu_hardwaresetup.h) and implementation (BSP/src/qomu_hardwaresetup.c). Former has an upper case 'S' and latter has an lower case 's'.
Due to this case issue a warning appear at compile time:
According to all examples name must be
qomu_hardwaresetup.Side question: quickfeather setup is called
qf_hardwareSetup(uppercase 'S') why not using same naming convention for Qomu?