fix: fall back to a Node scan when grep is unavailable#292
Open
dustinlacewell wants to merge 1 commit into
Open
fix: fall back to a Node scan when grep is unavailable#292dustinlacewell wants to merge 1 commit into
dustinlacewell wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: e69b73f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to upgrade my site to Qwik2 / Astro 6, every page dies with Q14 -- but only on Windows. It seems scanQwikEntrypoints in scan.ts shells out to grep with config.root.pathname as cwd which ends up being something like /C:/foo/bar/ so the spawn throws ENOENT and then the bare catch there eats it. The integration thinks there are no entrypoints, skips the standalone client build, no q-manifest.json exists and prerender time, Q14 on every QRL.
I got it fixed with a patch to use a pure-nodejs walk instead of the grep shell + fileURLToPath just to see if that was it, and it seemed to work.
This PR fixes the path format but also fallback to this node walk if grep is not available.