[AIMIGRAPHX-1057] Fix TheRock multi-arch packaging: use Recommends for per-GPU dependencies#4916
Open
kentqian wants to merge 7 commits into
Open
[AIMIGRAPHX-1057] Fix TheRock multi-arch packaging: use Recommends for per-GPU dependencies#4916kentqian wants to merge 7 commits into
kentqian wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts TheRock packaging dependency metadata so multi-arch “fat binary” packages don’t become uninstallable by requiring all per-GPU runtime libraries as hard dependencies, while keeping single-arch behavior unchanged.
Changes:
- Removes the hard requirement that
MIGRAPHX_THEROCK_GPU_ARCHmust be set when usingMIGRAPHX_PACKAGE_BACKEND=therock. - For multi-arch builds, moves per-GPU
amdrocm-dnn/amdrocm-blasdependencies from hardDependsintoRecommends(deb) /Suggests(rpm). - Adds an empty-arch “device-all” path that depends on arch-independent meta packages.
Comment on lines
+444
to
+448
| # Multi-arch fat binary: per-GPU libs are Recommends (only the | ||
| # libs for the GPU actually present are needed at runtime). | ||
| string(REPLACE ";" ", " _MGX_GPU_DEPS_CSV "${_MGX_GPU_DEPS}") | ||
| set(CPACK_DEBIAN_RUNTIME_PACKAGE_RECOMMENDS "${_MGX_GPU_DEPS_CSV}") | ||
| set(CPACK_RPM_PACKAGE_SUGGESTS "${_MGX_GPU_DEPS_CSV}") |
Comment on lines
+446
to
+448
| string(REPLACE ";" ", " _MGX_GPU_DEPS_CSV "${_MGX_GPU_DEPS}") | ||
| set(CPACK_DEBIAN_RUNTIME_PACKAGE_RECOMMENDS "${_MGX_GPU_DEPS_CSV}") | ||
| set(CPACK_RPM_PACKAGE_SUGGESTS "${_MGX_GPU_DEPS_CSV}") |
b1e20e8 to
b6b2096
Compare
kahmed10
reviewed
May 29, 2026
causten
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Multi-arch fat binary
.debpackages currently declare all per-GPU runtime dependencies (amdrocm-dnn,amdrocm-blas) as hardDepends. This makes the package uninstallable on any system that doesn't have all GPU arch libraries available — even if the user only has one GPU type.Technical Details
When
MIGRAPHX_THEROCK_GPU_ARCHcontains multiple architectures (e.g.gfx94x;gfx950;gfx110x;gfx120x), move per-GPUamdrocm-dnn/amdrocm-blasdependencies fromDependstoRecommends(deb) /Suggests(rpm). Only the libraries matching the GPU actually present are needed at runtime.Depends.device-allfallback path whenMIGRAPHX_THEROCK_GPU_ARCHis empty.FATAL_ERRORguard so thetherockbackend can be used without specifying GPU arch.Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable