Add layout algebra inference diagnostics#648
Draft
jhinpan wants to merge 3 commits into
Draft
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #583
Summary
fly.make_layoutwhen the shape and stride profiles are not congruent.fly.compositionwith a layout RHS so invalid static composition reports an MLIR diagnostic instead of tripping theLayoutUtilsassert.fly.logical_dividewith a layout divisor when both sizes are static and the divisor size does not divide the layout size.-verify-diagnosticscoverage for these invalid layout algebra cases.Scope
This is intentionally a small first pass. Dynamic divisibility is still deferred, and tile operands currently get profile checks rather than full admissibility checking.
Tests
cmake --build /sgl-workspace/FlyDSL-issue583/build-fly --target fly-opt -j$(nproc)/sgl-workspace/FlyDSL-issue583/build-fly/bin/fly-opt tests/mlir/LayoutAlgebra/invalid.mlir -verify-diagnosticstests/mlir/**/*.mlirRUN-line/FileCheck sweep with/sgl-workspace/FlyDSL-issue583/build-fly/bin/fly-opt