Skip to content

Bug/pd np version #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesETsmith wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Bug/pd np version #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5324078
Fixing test failures from new pandas version
jamesETsmith Mar 25, 2026
0d96660
Turning off one of the ffi-stream tests because it seems to rely on a…
jamesETsmith Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile.ci_gpu_rocm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ENV MAX_JOBS=${ARG_MAX_JOBS:-24}

# Install basic tools
RUN apt-get update \
&& apt install -y clang-format-15 ninja-build tree
&& apt install -y clang-format-15 git ninja-build tree
Copy link
Copy Markdown
Collaborator

@GMNGeoffrey GMNGeoffrey Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related?

Copy link
Copy Markdown
Collaborator Author

@jamesETsmith jamesETsmith Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely enough, git was missing and installing the graphbolt deps would crash because hipcollections would pull in it's own deps like libhipcxx with git and crash. I'm not sure why this wasn't popping up before. Maybe I didn't catch it with #16?


#Updating to latest version of Cmake for Ubuntu 22.04
RUN apt-get update && apt-get install -y wget build-essential \
Expand Down
4 changes: 2 additions & 2 deletions python/dgl/graphbolt/impl/ondisk_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ def _graph_data_to_fused_csc_sampling_graph(
src, dst = read_edges(dataset_dir, edge_fmt, edge_path)
edge_type_offset.append(edge_type_offset[-1] + len(src))
src_type, _, dst_type = etype_str_to_tuple(edge_info["type"])
src += node_type_offset[node_type_to_id[src_type]]
dst += node_type_offset[node_type_to_id[dst_type]]
src = src + node_type_offset[node_type_to_id[src_type]]
dst = dst + node_type_offset[node_type_to_id[dst_type]]
coo_src_list.append(torch.tensor(src))
coo_dst_list.append(torch.tensor(dst))
coo_etype_list.append(torch.full((len(src),), etype_id))
Expand Down
7 changes: 7 additions & 0 deletions tests/python/pytorch/test_ffi-stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,13 @@ def perform_computing():
@unittest.skipIf(
F._default_context_str == "cpu", reason="stream only runs on GPU."
)
@unittest.skipIf(
F.is_hip(),
reason=(
"ROCm allocator reuse differs from CUDA; this negative test depends on "
"nondeterministic block reuse."
),
)
def test_record_stream_graph_negative():
cycles_per_ms = _get_cycles_per_ms()

Expand Down
Empty file modified tests/scripts/task_unit_test_rocm.sh
100644 → 100755
View file
Open in desktop
Empty file.
Loading