Skip to content

GIM: init VF VRAM/GTT usage to sentinel on the SR-IOV host#79

Merged
sarat-k merged 1 commit into
ROCm:mainfrom
bhatturu:feat/gim-host-unsupported-sentinel
Jul 21, 2026
Merged

GIM: init VF VRAM/GTT usage to sentinel on the SR-IOV host#79
sarat-k merged 1 commit into
ROCm:mainfrom
bhatturu:feat/gim-host-unsupported-sentinel

Conversation

@bhatturu

Copy link
Copy Markdown
Contributor

Per-VF VRAM and GTT usage is not exposed to the host over SR-IOV, so the GIM host path cannot fill these fields. Sentinel-init stats->vram_usage so the unsupported members report NA in the exporter instead of a misleading 0 (total_vram is filled separately from vram_status). Mirrors the baremetal per-struct sentinel-init idiom.

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Comment thread sw/nic/gpuagent/api/smi/gimamdsmi/smi_api.cc
GIM host does not observe per-VCN/JPEG activity, XGMI link rx/tx,
PCIe rx/tx bytes, or per-VF VRAM/GTT usage. Sentinel-init these
structs before fill so DME reports NA instead of a bogus 0 that
failed test_metric_coverage; fields the stream populates overwrite
the sentinel. Mirrors the baremetal idiom in amdsmi/smi_api.cc.
@bhatturu
bhatturu force-pushed the feat/gim-host-unsupported-sentinel branch from a16af7e to 24e6b7d Compare July 21, 2026 15:05

@rsrikanth86 rsrikanth86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sarat-k
sarat-k merged commit 3c2838e into ROCm:main Jul 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants