[inductor] Make experimental benchmarker parameters configurable via env vars#3223
Open
tomjen12 wants to merge 1 commit into
Open
[inductor] Make experimental benchmarker parameters configurable via env vars#3223tomjen12 wants to merge 1 commit into
tomjen12 wants to merge 1 commit into
Conversation
Added environment variables to configure `estimation_iters`, `memory_warmup_iters`, `benchmark_iters`, and `max_benchmark_duration` for the experimental benchmarker. This allows users to tune the benchmarking process without modifying the source code, while preserving the original default values and respecting explicitly passed arguments.
|
Jenkins build for 2d745a70d0b5ee8c8b40ba0e7a0249d4fc97a465 commit finished as FAILURE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
The experimental benchmarker currently hardcodes parameters like
estimation_itersandmemory_warmup_iters. This PR makes them configurable via environment variables to allow easier tuning for different hardware and workloads without modifying source code.Added environment variables:
TORCHINDUCTOR_EXPERIMENTAL_BENCHMARKER_ESTIMATION_ITERS(default: 5)TORCHINDUCTOR_EXPERIMENTAL_BENCHMARKER_MEMORY_WARMUP_ITERS(default: 100)TORCHINDUCTOR_EXPERIMENTAL_BENCHMARKER_BENCHMARK_ITERS(default: 100)TORCHINDUCTOR_EXPERIMENTAL_BENCHMARKER_MAX_DURATION(default: 25)