Fix cpp-static-checks: build TableGen headers before clang-tidy#2398
Open
bogdan-petkovic wants to merge 2 commits into
Open
Fix cpp-static-checks: build TableGen headers before clang-tidy#2398bogdan-petkovic wants to merge 2 commits into
bogdan-petkovic wants to merge 2 commits into
Conversation
|
Signed-off-by: bogdan-petkovic <bpetkovi@amd.com>
Signed-off-by: bogdan-petkovic <bpetkovi@amd.com>
f2a076c to
897b2fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2398 +/- ##
===========================================
+ Coverage 79.50% 81.96% +2.45%
===========================================
Files 100 119 +19
Lines 31016 42672 +11656
Branches 4819 7082 +2263
===========================================
+ Hits 24659 34972 +10313
- Misses 4245 5070 +825
- Partials 2112 2630 +518
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After PR #2356 moved the C++ format/tidy premerge checks from Jenkins to GitHub Actions, the lint job stopped working on any PR whose diff transitively reaches a TableGen-generated
*.h.inc/*.cpp.inc(e.g. PR #2310). The Jenkins job ran on a fully built tree where these headers existed; the GHA job only rancmake -Sso clang-tidy hitfile not found.Technical Details
cmake --buildstep that buildsmlir-headersplus the orphanadd_public_tablegen_target()declarations from mlir-hal (3) and rocMLIR (7) that are not chained intomlir-headers. New orphan targets must be appended to this list.Adds ~7 minutes to the lint job wall time.
Test Plan
Re-run the cpp-static-checks job on a known previously-failing PR (#2310).
Test Result
Submission Checklist