Skip to content

[hiptensor] Several fixes and improvements for tests on Windows#6462

Merged
evedovelli merged 3 commits intodevelopfrom
users/evedovel/hiptensor/several-test-fixes-for-windows
Apr 17, 2026
Merged

[hiptensor] Several fixes and improvements for tests on Windows#6462
evedovelli merged 3 commits intodevelopfrom
users/evedovel/hiptensor/several-test-fixes-for-windows

Conversation

@evedovelli
Copy link
Copy Markdown
Contributor

Motivation

Improve reliability of tests and fix Windows specific errors.

Technical Details

  • Fix cleanup on yaml_test
  • Add extra datatype for plan cache tests to perform test on all ASICs
  • Fix error when providing stride data on reduction_test
  • Copy relevant amd*.dll to hiptensor/bin path so they have priority over the system DLLs
  • Force HIP runtime initialization before any test to get a clean error in case cause of issues

Test Plan

Run full set of tests on Windows and on Linux.

Test Result

  • Tests are passing.

Submission Checklist

- Fix cleanup on yaml_test
- Add extra datatype for plan cache tests to perform test on all ASICs
- Fix error when providing stride data on reduction_test
- Copy relevant amd*.dll to hiptensor/bin path so they have priority over the system DLLs
- Force HIP runtime initialization before any test to get a clean error in case cause of issues
Copy link
Copy Markdown
Contributor

@Ryker0627 Ryker0627 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread projects/hiptensor/library/src/include/logger.hpp Outdated
Comment thread projects/hiptensor/test/hiptensor_gtest_main.cpp Outdated
Comment thread projects/hiptensor/test/CMakeLists.txt Outdated
@evedovelli evedovelli enabled auto-merge (squash) April 17, 2026 14:54
@evedovelli evedovelli merged commit d41d078 into develop Apr 17, 2026
9 checks passed
@evedovelli evedovelli deleted the users/evedovel/hiptensor/several-test-fixes-for-windows branch April 17, 2026 17:45
assistant-librarian bot pushed a commit to ROCm/hipTensor that referenced this pull request Apr 17, 2026
[hiptensor] Several fixes and improvements for tests on
 Windows (#6462)

## Motivation

Improve reliability of tests and fix Windows specific errors.

## Technical Details

- Fix cleanup on yaml_test
- Add extra datatype for plan cache tests to perform test on all ASICs
- Fix error when providing stride data on reduction_test
- Copy relevant amd*.dll to hiptensor/bin path so they have priority
over the system DLLs
- Force HIP runtime initialization before any test to get a clean error
in case cause of issues

## Test Plan

Run full set of tests on Windows and on Linux.

## Test Result

- Tests are passing.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants