Skip to content

[hipDNN] Fix unstable user log test.#6471

Merged
CMiservaAMD merged 3 commits intodevelopfrom
users/cmiserva/rocm-21356/fix-backend-logger-test
Apr 16, 2026
Merged

[hipDNN] Fix unstable user log test.#6471
CMiservaAMD merged 3 commits intodevelopfrom
users/cmiserva/rocm-21356/fix-backend-logger-test

Conversation

@CMiservaAMD
Copy link
Copy Markdown
Contributor

Motivation

Test was susceptible to race conditions.

Technical Details

Replaced sleep() with signals between threads to ensure threads were run to generate the needed data for the test.

Test Plan

Test Result

Submission Checklist

@CMiservaAMD CMiservaAMD requested a review from a team as a code owner April 15, 2026 22:33
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (47.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6471      +/-   ##
===========================================
+ Coverage    66.59%   66.60%   +0.01%     
===========================================
  Files         2176     2177       +1     
  Lines       321082   321475     +393     
  Branches     41481    41539      +58     
===========================================
+ Hits        213810   214101     +291     
- Misses       92635    92712      +77     
- Partials     14637    14662      +25     
Flag Coverage Δ *Carryforward flag
hipBLAS 90.67% <ø> (ø) Carriedforward from 72d355b
hipBLASLt 39.95% <ø> (ø) Carriedforward from 72d355b
hipCUB 82.21% <ø> (ø) Carriedforward from 72d355b
hipDNN 82.41% <100.00%> (-0.07%) ⬇️
hipFFT 55.00% <ø> (ø) Carriedforward from 72d355b
hipRAND 76.12% <ø> (ø) Carriedforward from 72d355b
rocBLAS 48.11% <ø> (ø) Carriedforward from 72d355b
rocFFT 47.50% <ø> (ø) Carriedforward from 72d355b
rocPRIM 38.96% <ø> (ø) Carriedforward from 72d355b
rocRAND 57.09% <ø> (ø) Carriedforward from 72d355b
rocSPARSE 71.52% <ø> (ø) Carriedforward from 72d355b
rocThrust 91.37% <ø> (ø) Carriedforward from 72d355b

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../include/hipdnn_test_sdk/utilities/LogRecorder.hpp 99.14% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread projects/hipdnn/backend/tests/TestUserLoggingApis.cpp Outdated
Comment thread projects/hipdnn/backend/tests/TestUserLoggingApis.cpp Outdated
Copy link
Copy Markdown
Contributor

@SamuelReeder SamuelReeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM! Potentially minor comments, but I think they're worth addressing.

CMiservaAMD and others added 2 commits April 16, 2026 00:20
Co-authored-by: Samuel Reeder <41528605+SamuelReeder@users.noreply.github.com>
@CMiservaAMD CMiservaAMD enabled auto-merge (squash) April 16, 2026 06:53
@CMiservaAMD CMiservaAMD merged commit dcb02f1 into develop Apr 16, 2026
23 checks passed
@CMiservaAMD CMiservaAMD deleted the users/cmiserva/rocm-21356/fix-backend-logger-test branch April 16, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants