[hipDNN] Fix unstable user log test.#6471
Merged
CMiservaAMD merged 3 commits intodevelopfrom Apr 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (47.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6471 +/- ##
===========================================
+ Coverage 66.59% 66.60% +0.01%
===========================================
Files 2176 2177 +1
Lines 321082 321475 +393
Branches 41481 41539 +58
===========================================
+ Hits 213810 214101 +291
- Misses 92635 92712 +77
- Partials 14637 14662 +25
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
SamuelReeder
approved these changes
Apr 15, 2026
Contributor
SamuelReeder
left a comment
There was a problem hiding this comment.
Generally LGTM! Potentially minor comments, but I think they're worth addressing.
Co-authored-by: Samuel Reeder <41528605+SamuelReeder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Test was susceptible to race conditions.
Technical Details
Replaced sleep() with signals between threads to ensure threads were run to generate the needed data for the test.
Test Plan
Test Result
Submission Checklist