Skip to content

Add clickable PR links in update changelog#18465

Open
Kravickas wants to merge 23 commits intoRPCS3:masterfrom
Kravickas:master
Open

Add clickable PR links in update changelog#18465
Kravickas wants to merge 23 commits intoRPCS3:masterfrom
Kravickas:master

Conversation

@Kravickas
Copy link
Copy Markdown
Contributor

@Kravickas Kravickas commented Mar 28, 2026

Replaces the plain text "Show Details" changelog in the update dialog with a QTextBrowser that converts PR references like (#1234) into clickable GitHub links.

Why? : Easy to check PRs you are interested in beyond the title.

PR closed

Master closed

PR opened

Master open

Added support for displaying changelog with clickable PR links in update dialog.
@Megamouse Megamouse added the GUI label Mar 28, 2026
@AniLeo
Copy link
Copy Markdown
Member

AniLeo commented Mar 28, 2026

Have you actually tested this?

How is this even supposed to work if the Pull Request information is not sent on the changelog in the first place?

@qurious-pixel
Copy link
Copy Markdown
Contributor

@Kravickas were you able to get html formatting in QMessageBox?
detailed text property is always converted to plain text.

@Kravickas
Copy link
Copy Markdown
Contributor Author

Kravickas commented Mar 28, 2026

No, and now it will need API update, with PR numbers for each entry, just like it does for current and latest right now.


Not through setDetailedText(). QTextBrowser is injected into the QMessageBox's internal QGridLayout and renders the changelog as HTML. setOpenExternalLinks(true) makes the PR links clickable.

@Kravickas
Copy link
Copy Markdown
Contributor Author

@AniLeo UI is ready in my opinion, test code waiting for pr addition in the api.

@AniLeo
Copy link
Copy Markdown
Member

AniLeo commented Apr 4, 2026

Added on AniLeo/rpcs3-compatibility@a46fd38

@Kravickas
Copy link
Copy Markdown
Contributor Author

Thanks, works.
Main post have updated screenshots with final version before reviews.

@Kravickas Kravickas marked this pull request as ready for review April 4, 2026 13:24
@Megamouse
Copy link
Copy Markdown
Contributor

Why not have the PR number at the beginning?

@Kravickas
Copy link
Copy Markdown
Contributor Author

Kravickas commented Apr 4, 2026

To be honest, I wasn't thinking about that. It's just how I was inspired.

You should be allowed for edits, you can change it if you want as QT leader. :)

Or just let me know what do you want

    • Present
    • (#18459) 0.0.40-19111: SaveStates: Fix restart after saving
    • 0.0.40-19111 (#18459): SaveStates: Fix restart after saving

@AniLeo
Copy link
Copy Markdown
Member

AniLeo commented Apr 4, 2026

Definitely not just the PR number. Either what we already have, or appended with (#PR)

Comment thread rpcs3/rpcs3qt/update_manager.cpp Outdated
@AniLeo
Copy link
Copy Markdown
Member

AniLeo commented Apr 5, 2026

Please squash in how many commits you find relevant, rebase, and then request a review when you're done with all the changes

@digant73
Copy link
Copy Markdown
Contributor

digant73 commented Apr 9, 2026

Definitely not just the PR number. Either what we already have, or appended with (#PR)

    • (#18459) 0.0.40-19111: SaveStates: Fix restart after saving
    • 0.0.40-19111 (#18459): SaveStates: Fix restart after saving
    • 0.0.40-19111: SaveStates: Fix restart after saving (#18459)

I would choose 2. Build number and PR would be aligned in the same column in the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants