Add clickable PR links in update changelog#18465
Add clickable PR links in update changelog#18465Kravickas wants to merge 23 commits intoRPCS3:masterfrom
Conversation
Added support for displaying changelog with clickable PR links in update dialog.
|
Have you actually tested this? How is this even supposed to work if the Pull Request information is not sent on the changelog in the first place? |
|
@Kravickas were you able to get html formatting in QMessageBox? |
|
No, and now it will need API update, with PR numbers for each entry, just like it does for current and latest right now. Not through setDetailedText(). QTextBrowser is injected into the QMessageBox's internal QGridLayout and renders the changelog as HTML. setOpenExternalLinks(true) makes the PR links clickable. |
|
@AniLeo UI is ready in my opinion, test code waiting for pr addition in the api. |
|
Added on AniLeo/rpcs3-compatibility@a46fd38 |
|
Thanks, works. |
|
Why not have the PR number at the beginning? |
|
To be honest, I wasn't thinking about that. It's just how I was inspired. You should be allowed for edits, you can change it if you want as QT leader. :) Or just let me know what do you want
|
|
Definitely not just the PR number. Either what we already have, or appended with (#PR) |
|
Please squash in how many commits you find relevant, rebase, and then request a review when you're done with all the changes |
I would choose 2. Build number and PR would be aligned in the same column in the list |
Replaces the plain text "Show Details" changelog in the update dialog with a QTextBrowser that converts PR references like (#1234) into clickable GitHub links.
Why? : Easy to check PRs you are interested in beyond the title.
PR closed


Master closed
PR opened


Master open