Skip to content

suppress warnings#2925

Closed
UnArbosSix wants to merge 2 commits into
stagingfrom
suppress-vendored-warnings
Closed

suppress warnings#2925
UnArbosSix wants to merge 2 commits into
stagingfrom
suppress-vendored-warnings

Conversation

@UnArbosSix

@UnArbosSix UnArbosSix commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Suppresses five compiler warnings emitted by vendored Frontier and w3f-bls sources. The warnings concern elided lifetime syntax, an unused BLS context constant, and a no-op clone.

Files of interest

  • vendor/frontier/client/rpc/src/eth/pending.rs
  • vendor/frontier/precompiles/src/evm/handle.rs
  • vendor/w3f-bls/src/double_pop.rs
  • vendor/w3f-bls/src/verifiers.rs

Behavioral impact

No runtime behavior or public API is intended to change; this PR adds lint-suppression attributes only.

Migration and spec version

No migration or runtime spec-version bump is required.

Testing

Not performed; the changes are lint attributes only.

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview, Comment Jul 16, 2026 1:59pm

Request Review

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

VERY HIGH account-age scrutiny, mitigated by repository write access; no Gittensor match and author/committer match; suppress-vendored-warnings → staging.

Findings

No findings.

Conclusion

The diff contains only narrowly scoped lint-suppression attributes in vendored sources and introduces no security-relevant behavior changes.


🔍 AI Review — Auditor (domain review)

VERDICT: 👎

UNKNOWN Gittensor association; very new account, mitigated by repository write access.

PR #2913 remains open, overlaps all four changed files, and fixes these warnings at their sources: explicit lifetimes, removal of the unused constant, and elimination of the no-op clone. It also fixes an additional warning. PR #2913 is the better candidate. Recommend closing this one.

No build or spec-version bump is needed for this vendored, lint-only diff.

Findings

Sev File Finding
MEDIUM PR #2913 Duplicate of the more complete warning cleanup (off-diff)

Other findings

Prior-comment reconciliation

  • dfe217fa: not addressed — PR Fix build warnings #2913 remains open and still overlaps all four files changed by this PR.

Conclusion

The changes are behaviorally low-risk, but this PR remains an inferior duplicate of #2913.


📜 Previous run (superseded)
Sev File Finding Status
MEDIUM PR #2913 Duplicate of the more complete warning cleanup ➡️ Carried forward to current findings
PR #2913 remains open and still overlaps all four files changed by this PR.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

Comment thread pallets/subtensor/src/subnets/leasing.rs Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: VULNERABLE

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

@unarbos

unarbos commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Landed in staging via #2927 (cherry-picked, one squashed commit per PR).

@unarbos unarbos closed this Jul 16, 2026
@unarbos
unarbos deleted the suppress-vendored-warnings branch July 16, 2026 14:47
loom-agent pushed a commit to loom-agent/subtensor that referenced this pull request Jul 16, 2026
…aoFoundation#2913 code fixes, no diff

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants