fix: Treat the flyout as a listbox with options#10059
Merged
gonfunko merged 1 commit intoJun 24, 2026
Merged
Conversation
gonfunko
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10058
Proposed Changes
Change the flyout from a list to listbox and flyout items from listitems to options.
Subsequently, clickable icons in the flyout need to be owned (using aria-owns) by their parent block to avoid inflating the number of options that the screen reader counts. This PR also introduces more safety with icons by making them inert in the flyout when they are not clickable.
Reason for Changes
This fixes compatibility with Windows narrator without regressing other screen readers (VoiceOver, NVDA, JAWS, ChromeVox)
Test Coverage
Updated one existing change to assert option instead of listitem.
Documentation
None
Additional Information
An alternative fix could be to avoid using aria-label in the flyout, and instead use a visually hidden element that contains the aria-label text, but I have not explored or test this version.