fix: scope passive block focus to keyboard navigation#10063
Merged
mikeharv merged 1 commit intoJun 24, 2026
Merged
Conversation
The passive-focus selector for blocks and connection paths lacked the .blocklyKeyboardNavigation gate that the sibling field and icon selectors in the same rule already have, so passive block outlines leaked into mouse-only usage. It also never honored the dropdown/widget-div guard its own comment promised. Scope it identically to the field/icon selectors. Closes RaspberryPiFoundation#10062
mikeharv
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The passive-focus selector for blocks and connection paths lacked the .blocklyKeyboardNavigation gate that the sibling field and icon selectors in the same rule already have, so passive block outlines leaked into mouse-only usage. It also never honored the dropdown/widget-div guard its own comment promised. Scope it identically to the field/icon selectors.
The basics
The details
Resolves
Fixes #10062
Proposed Changes
Reason for Changes
Test Coverage
Documentation
Additional Information