fix: Make dialog handling of ephemeral focus more robust#10064
Merged
Conversation
lizschwab
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR makes the dialog system check to ensure that nothing else is holding ephemeral focus before attempting to claim it itself. Claiming ephemeral focus when it is already held throws, and this could be triggered by e.g. showing a dialog from content in a widgetdiv (which already/also claims ephemeral focus). Now, if ephemeral focus is held, the dialog system doesn't claim it, and when the dialog reference count reaches 0, it will not attempt to restore focus since it won't hold a callback to invoke.