test: use valid empty-symbol literal for null-symbol round-trip#2
Open
belowzeroff wants to merge 1 commit into
Open
test: use valid empty-symbol literal for null-symbol round-trip#2belowzeroff wants to merge 1 commit into
belowzeroff wants to merge 1 commit into
Conversation
The server type-matrix test and the real-q interop script both asserted on `0Ns`, but Rayfall has no `0Ns` literal — the engine parses it as a name and signals 'name, so `make test` failed at types.rfl:50 on a clean checkout (0Nl / 0Ni / 0Nf are fine; only 0Ns is invalid). Write the null symbol as the empty symbol `(as 'sym "")`, which the engine accepts and which round-trips over the wire (a -KS atom with a zero-length name). Server legs now pass 32/32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make testfails on a clean checkout attest/rfl/server/types.rfl:50:The server type-matrix test and the real-q interop script (
test/run.sh) bothassert on
0Ns, but Rayfall has no0Nsliteral — the engine parses it asa name and signals
'name. (0Nl/0Ni/0Nfare valid; only0Nsisnot.) So the null-symbol row breaks the server round-trip suite.
Fix
Write the null symbol as the empty symbol
(as 'sym ""), which the engineaccepts and which round-trips over the wire (a
-KSatom with a zero-lengthname). Same substitution applied to the real-q interop assertion in
test/run.sh(compared against q's`).Validation
Empty-symbol round-trip confirmed end-to-end against
driver --serve;0Nl/0Ni/0Nfcontinue to pass.🤖 Generated with Claude Code