fix(jump-links): non-contiguous content#2471
fix(jump-links): non-contiguous content#2471tejas161 wants to merge 14 commits intoRedHat-UX:mainfrom
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@tejas161 test this by pulling latest commit and running |
|
Thanks @bennypowers for pushing the fix ! Here is what I observed:
Would it be possible to always target the section at the top of the viewport, similar to the behavior shown here: https://ux.redhat.com/elements/jump-links/demo/nested/? Let me know what you think! Attaching video of observed behaviour:- |
|
This isn't quite ready yet. @tejas161 ' most recent feedback on https://deploy-preview-2471--red-hat-design-system.netlify.app/elements/jump-links/demo/non-contiguous-regions/#chapter-5
Screen.Recording.2025-08-06.at.17.28.10.mov@adamjohnson can you give this a whack in patternfly/patternfly-elements#2920? |
Michal7290
left a comment
There was a problem hiding this comment.
The problem Benny mentioned - that the active button appears in the delay - I can reproduce it.
|
This is now superseded by the upstream fix in @patternfly/pfe-core 5.0.7, which fixes the scroll-spy-controller's |
|
Closed by #2863 |
What I did
Testing Instructions
Notes to Reviewers
See #2474 for more info.