Draft
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +131 B (+0.05%) Total Size: 257 kB
ℹ️ View Unchanged
|
zeroedin
reviewed
Oct 23, 2025
Comment on lines
+23
to
+29
| /* doesn't work */ | ||
| --pf-c-select__menu-item--hover--BackgroundColor: var(--rh-color-surface-lighter); | ||
|
|
||
| /* doesn't work */ | ||
| --pf-c-select__menu-item--focus--BackgroundColor: var(--rh-color-surface-lighter); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
if we update to @patternfly/elements@4.2.0 we can do this nasty hack:
pf-option {
--rh-color-gray-20:
light-dark(
var(--rh-color-surface-lighter),
var(--rh-color-surface-dark)
) !important;
--_pf-option-selected-background-color:
light-dark(
var(--rh-color-surface-lighter),
var(--rh-color-surface-dark)
) !important;
--_svg-color: var(--rh-color-interactive-primary-default);
}
}
Collaborator
There was a problem hiding this comment.
also there is a rouge --rh-color-gray-20 in PFE that shouldn't be there 🙃
Member
Author
There was a problem hiding this comment.
@dali327519294 can you continue this PR, instead of patternfly/patternfly-elements#2952?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Testing Instructions
Notes to Reviewers
pf-select's css is broken, and doesn't actually support theming
Closes #2681