Skip to content

fix: fix advisories cards breakpoints and spacing - #1724

Open
Dugowitch wants to merge 2 commits into
RedHatInsights:masterfrom
Dugowitch:advisories-cards
Open

fix: fix advisories cards breakpoints and spacing#1724
Dugowitch wants to merge 2 commits into
RedHatInsights:masterfrom
Dugowitch:advisories-cards

Conversation

@Dugowitch

@Dugowitch Dugowitch commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

Associated Jira ticket: HMS-10843

Fix advisories cards brakpoints to prevent the left and right side from touching.
Increase line height in the card so that the item are not so squashed.

How to test the PR

Before the change

Screenshot From 2026-07-30 11-09-24

After the change

Screenshot From 2026-07-30 11-09-32

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@Dugowitch
Dugowitch requested a review from a team as a code owner July 30, 2026 09:12
@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.30%. Comparing base (c0d2b77) to head (d2503b6).

Files with missing lines Patch % Lines
...Components/StatusReports/AdvisoriesStatusReport.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1724   +/-   ##
=======================================
  Coverage   77.30%   77.30%           
=======================================
  Files         101      101           
  Lines        3270     3270           
  Branches      740      740           
=======================================
  Hits         2528     2528           
  Misses        663      663           
  Partials       79       79           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dugowitch

Copy link
Copy Markdown
Contributor Author

Hi @MariSvirik, we talked abut the card item spacing. I increased the line height to 2 and think it looks much better. I'd love to know what you think!

TenSt
TenSt previously approved these changes Jul 30, 2026

@TenSt TenSt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TenSt TenSt self-assigned this Jul 30, 2026
@Dugowitch
Dugowitch enabled auto-merge (squash) July 30, 2026 14:17
@Dugowitch
Dugowitch disabled auto-merge July 30, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants