WIP: [storage] De-quarantine HTTP import test_invalid_url#4862
WIP: [storage] De-quarantine HTTP import test_invalid_url#4862ema-aka-young wants to merge 2 commits into
Conversation
Signed-off-by: Emanuele Prella <eprella@redhat.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR removes an unused import and enables a previously failing test. The ChangesHTTP import test cleanup
🎯 1 (Trivial) | ⏱️ ~5 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/wip |
ema-aka-young
changed the title
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-4
requested review from
Ahmad-Hafe and
dalia-frank
openshift-virtualization-qe-bot-4
requested review from
acinko-rh,
jpeimer,
kgoldbla and
kshvaika
openshift-virtualization-qe-bot-2
changed the title
|
/build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=f48f223f65196401f3293e1e1965de01d0fe6b29 |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4862 published |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
/verified |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Repository: RedHatQE/openshift-virtualization-tests 🏁 Script executed: Repository: RedHatQE/openshift-virtualization-tests 🏁 Script executed: Length of output: 0 🏁 Script executed: Length of output: 76 🏁 Script executed: Repository: RedHatQE/openshift-virtualization-tests Test Execution Plan
|
|
/build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=3da59552a05b110337efab323505e07429ddbfcb |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4862 published |
|
/build-and-push-container OPENSHIFT_PYTHON_WRAPPER_COMMIT=dc95f112c24d3ec4eeddff98d12746b106b89bce |
|
Verification failed for PR #4862. |
|
Verification failed for PR #4862. |
|
/build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=dc95f112c24d3ec4eeddff98d12746b106b89bce |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4862 published |
|
/verified All tests passed for PR #4862 (image: openshift-virtualization-tests:pr-4862). |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| wait_for_dv_condition_message, | ||
| ) | ||
| from utilities.constants import ( | ||
| QUARANTINED, |
There was a problem hiding this comment.
Test Execution Plan
- Run smoke tests: False — No smoke markers in
test_import_http.py; no transitive dependency path from smoke tests to this file. - Run gating tests: False — Gating-marked tests in this file (lines 85, 155) are not modified by this PR.
Affected tests to run:
tests/storage/cdi_import/test_import_http.py::test_invalid_url—xfail(run=False)removed; must now pass cleanly.
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get PR diff to find first changed line
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/4862/files --jq '.[] | {filename: .filename, patch: .patch}'
# Check smoke tests
echo "=== Smoke-marked test files ==="
rg -l '`@pytest.mark.smoke`' tests/ --type py 2>/dev/null | head -20
# Check gating tests
echo "=== Gating-marked test files ==="
rg -l '`@pytest.mark.gating`' tests/ --type py 2>/dev/null | head -20
# Check if test_import_http is in smoke or gating files
echo "=== Smoke/gating in test_import_http.py ==="
rg '`@pytest.mark.smoke`|`@pytest.mark.gating`' tests/storage/cdi_import/test_import_http.py -n || echo "None"
# Get the actual line numbers from the diff
echo "=== PR file diff ==="
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/4862/files --jq '.[] | .patch' 2>/dev/nullLength of output: 3488 🏁 Script executed: #!/bin/bash
# Get the latest commit SHA for the PR to post inline comment
COMMIT_SHA=$(gh api repos/RedHatQE/openshift-virtualization-tests/pulls/4862 --jq '.head.sha')
echo "Commit SHA: $COMMIT_SHA"
# Post inline review comment on first changed line (deletion of QUARANTINED at original line 27)
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/4862/reviews \
--method POST \
--field commit_id="$COMMIT_SHA" \
--field event="COMMENT" \
--field body="" \
--field "comments[][path]=tests/storage/cdi_import/test_import_http.py" \
--field "comments[][line]=27" \
--field "comments[][side]=LEFT" \
--field "comments[][body]=**Test Execution Plan**
- **Run smoke tests: False** — No smoke markers in \`test_import_http.py\`; no transitive dependency path from smoke tests to this file.
- **Run gating tests: False** — Gating-marked tests in this file (lines 85, 155) are not modified by this PR.
**Affected tests to run:**
- \`tests/storage/cdi_import/test_import_http.py::test_invalid_url\` — \`xfail(run=False)\` removed; must now pass cleanly."Length of output: 2911 🧠 Learnings used |
6 participants
Short description:
Dequarantine
cdi_import/test_import_http.py::test_invalid_url.More details:
This PR is part of a multi-step task that deprecates
DataVolume.wait()and falls back to the parentResource.wait()method in the wrapper. Previously, this test was relying on that method and hence failing.What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
This PR depends on this wrapper patch.
jira-ticket:
https://redhat.atlassian.net/browse/CNV-73197
Summary by CodeRabbit