Skip to content

Use timeout instead of num_sec#199

Open
LadislavVasina1 wants to merge 1 commit into
RedHatQE:masterfrom
LadislavVasina1:wait-for-timeout
Open

Use timeout instead of num_sec#199
LadislavVasina1 wants to merge 1 commit into
RedHatQE:masterfrom
LadislavVasina1:wait-for-timeout

Conversation

@LadislavVasina1
Copy link
Copy Markdown

@LadislavVasina1 LadislavVasina1 commented Jun 2, 2026

Future release of wait_for will deprecate num_sec parameter and timeout usage with time as a string value.
This PR makes changes based on this.

Related PRs:
RedHatQE/widgetastic.core#309
RedHatQE/widgetastic.patternfly5#125

Summary by Sourcery

Update wait_for usage to rely on the timeout parameter instead of the deprecated num_sec and string-based time values.

Enhancements:

  • Use the timeout argument consistently in widget navigation and chip group helpers to align with upcoming wait_for API changes.
  • Correct a typo in the chip removal wait message text.

Tests:

  • Update pagination and card view tests to use the timeout argument with numeric values instead of num_sec or string-based durations.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 2, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replace deprecated wait_for num_sec parameter and string-based timeout usage with the new timeout integer parameter across chipgroup, navigation, and pagination components and tests.

Sequence diagram for wait_for timeout usage in chipgroup

sequenceDiagram
    participant Chip as Chip
    participant Button as ChipButton
    participant wait_for as wait_for

    Chip->>Button: click()
    Chip->>wait_for: wait_for(_gone, timeout=3, delay=0.1, message="wait for chip to disappear")
    wait_for-->>Chip: _gone returns True
Loading

File-Level Changes

Change Details Files
Update wait_for calls to use the new timeout parameter and fix a minor typo in a message string.
  • Replace num_sec argument with timeout in all wait_for calls in chip group widget methods that wait for chip removal and show more/less buttons.
  • Replace num_sec with timeout in navigation loaded check that waits for data-ouia-safe to become true.
  • Replace num_sec with timeout in pagination-related fixtures that wait for paginator visibility in both ouia and standard pagination tests.
  • Change timeout from a string value ('15s') to an integer 15 in card view tests to align with new wait_for API expectations.
  • Correct a misspelling of 'disappear' in a wait_for message string in chipgroup.
src/widgetastic_patternfly4/chipgroup.py
src/widgetastic_patternfly4/navigation.py
testing/ouia/test_pagination_ouia.py
testing/test_cardview.py
testing/test_pagination.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LadislavVasina1
Copy link
Copy Markdown
Author

pre-commit.ci autofix

@mshriver
Copy link
Copy Markdown
Contributor

mshriver commented Jun 2, 2026

the gitlab workflows for the legacy branch will require updates to continue to function.

@LadislavVasina1
Copy link
Copy Markdown
Author

@mshriver should it be fixed within this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants