add bash to exec if available. If not, fallback to sh#64
Open
a-peri wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the container exec command to prefer bash when available, falling back to sh, while preserving the existing spawn behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The nested quoting (
'docker exec ... bash || docker exec ... sh; exec $SHELL') is getting hard to read and reason about; consider switching to a template literal and/orsh -cinside the container to make the fallback logic and quoting clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The nested quoting (`'docker exec ... bash || docker exec ... sh; exec $SHELL'`) is getting hard to read and reason about; consider switching to a template literal and/or `sh -c` inside the container to make the fallback logic and quoting clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the "Exec" action for containers in src/docker.js:167.
Before: The exec command always used sh as the shell inside the container.
After: It first tries bash, and only falls back to sh if bash isn't available.
Summary by Sourcery
Update container exec action to prefer running an interactive bash shell and fall back to sh when bash is unavailable.