Skip to content

Fix embedded pdf path to github-account-security.mdx#328

Merged
Mouse933 merged 2 commits into
Redback-Operations:mainfrom
inaambaj:patch-2
May 19, 2026
Merged

Fix embedded pdf path to github-account-security.mdx#328
Mouse933 merged 2 commits into
Redback-Operations:mainfrom
inaambaj:patch-2

Conversation

@inaambaj

Copy link
Copy Markdown
Contributor

Please check the following - and then delete this message:

  • If you are creating a new page, does it contain the following value at the top, with x being the position in the folder?
---
sidebar_position: x
---
  • If you are creating a new sub-folder, does it have a _category_.json file with the appropriate descriptive information?
  • Are all your images / videos named appropriately and in the correct location ("image1.png" e.g. will not be accepted)
  • Are all your code blocks properly closed off?
  • Does your file have an appropriate and descriptive file name, and main header?
  • Ensure all files are referenced correctly (They are case sensitive - if you save "image.png" you cannot reference "Image.PNG")

Failure to include these will result in your request not being reviewed.

@inaambaj inaambaj requested review from a team as code owners April 24, 2026 06:28

@VishalAbiman05 VishalAbiman05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security review – PR #328

This change replaces an absolute URL with a relative path for a PDF embed.
This is good practice because it avoids external dependencies and reduces the risk of content injection or MITM attacks if the external domain were compromised.

No security issues found.

@Mouse933 Mouse933 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed by Vishal, no issues found. Approving to push to main :)

@Mouse933 Mouse933 merged commit 83cf883 into Redback-Operations:main May 19, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants