Conversation
2. make comparison non-case sensitve
meiravgri
changed the title
ikalchev
approved these changes
Apr 2, 2026
ikalchev
approved these changes
Apr 3, 2026
| words = parts[0].split() | ||
| if len(words) % 2 != 0: | ||
| print(Colors.Bred(f"Error in args: odd number of words in key-value pairs: '{modulesArgs}'. " | ||
| f"Use semicolons to separate args with multiple values (e.g. 'KEY1 V1; KEY2 V2 V3').")) |
Collaborator
There was a problem hiding this comment.
nit: f-string not needed here.
GuyAv46
approved these changes
Apr 5, 2026
ofiryanai
added a commit
to ofiryanai/RLTest
that referenced
this pull request
Apr 8, 2026
The key-value pair splitting introduced in PR RedisLabsModules#243 changes how args are passed to Redis loadmodule, breaking modules that expect the original single-string format. This caused silent Redis server crashes in CI multiprocessing workers. Revert to pre-v0.7.22 behavior: when no semicolons are present, keep the entire string as a single arg. The case-insensitive arg matching from PR RedisLabsModules#243 is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix_modulesArgsdidn't handle plain space-separated key-value strings likeEnv(moduleArgs='_FREE_RESOURCE_ON_THREAD FALSE TIMEOUT 80 WORKERS 4'). Without semicolons, the entire string was treated as a single arg with_FREE_RESOURCE_ON_THREADas the name, making it impossible to override individual defaults.Additionally, arg name matching between explicit args and defaults was case-sensitive, so
WORKERS 4wouldn't override a defaultworkers 8.Solution:
'K1 V1 K2 V2'→['K1 V1', 'K2 V2']..upper()normalization). The actual arg strings keep their original casing.