Enable interactive input for dotnetup prompts - #218
Merged
Conversation
Forward opt-in xterm input to active process stdin so dotnetup setup menus can accept navigation and confirmation keys. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4ae088bc-2250-4e42-a218-731f5d7d76d3
Redth
added a commit
that referenced
this pull request
Jul 29, 2026
Both branches independently added standard input support to IProcessExecutionService: main added SendInputAsync for dotnetup's interactive prompts (#218), and this branch added WriteInputAsync to drive the MAUI CLI's start/stop recording prompts. Converged on main's SendInputAsync and removed WriteInputAsync. Main's version is the better contract: it returns false rather than throwing when the process can no longer accept input, requires callers to opt in via ProcessRequest.AcceptsStandardInput, rejects elevated processes, and serializes writes against Cancel() and process disposal so stdin cannot be closed mid-write. MauiProfilingCliService now sets AcceptsStandardInput for interaction captures and sends Environment.NewLine through SendInputAsync, throwing if the CLI has stopped accepting input. ProcessExecutionService keeps the improvements from both sides: main's input serialization plus this branch's output-builder locking and the Cancel() hardening that kills the process tree instead of only cancelling the linked token source. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c34731b-bd7f-47de-b52b-ad36257ab3b4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dotnetupcan display a terminal setup menu during SDK installation, but Sherpa's process modal was output-only. The process remained blocked because users could not send arrow keys or Enter to the running command.What changed
dotnetupSDK installs on Apple pseudo-terminals, including tracked-channel installs.Validation
DotnetUpServiceTestsFixes: #203