AB#133167 Improve performance on forms#2866
Open
Maximo-reliefapps wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves form performance and prevents memory leaks by cleaning up SurveyJS event handlers, RxJS subscriptions, and active HTTP requests during the component lifecycle.
Changes
Cancel In-Flight Requests: Triggers .next() on the existing refresh$ Subject during re-renders to cancel any pending HTTP requests before re-registering.
Deduplicate Event Listeners: Stored anonymous handlers as named references (_gqlLinkedChoicesHandler and _gqlValueUpdateHandler) on the question object. Used a remove-before-add pattern to prevent duplicate listeners.
Question-Level Guard: Added a _referenceDataPropertyHandlersRegistered flag to ensure handlers register only once per question lifetime.
Survey-Level Cleanup: Applied the remove-before-add pattern to _referenceDataLinkedHandler and called unregisterFunctionOnPropertyValueChanged to clean up the refreshData handler.
-vMutation Guards: Added pipe(takeUntil(this.destroy$)) to the onComplete and confirmRevertDialog mutation subscriptions to prevent callbacks from running after the component is destroyed.
Useful links
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Screenshots
No visual changes
Checklist:
( * == Mandatory )