Skip to content

RIC-T40 Call notes and Inbox fix #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucswift merged 2 commits into from
Jul 26, 2026
Merged

RIC-T40 Call notes and Inbox fix #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93967fb
RIC-T40 Call notes and Inbox fix
ucswift Jul 26, 2026
a82e9a2
RC-T40 PR#24 fixes
ucswift Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 144 additions & 92 deletions src/components/calls/__tests__/call-notes-modal-new.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,24 @@ jest.mock('lucide-react-native', () => {
jest.mock('../../common/loading', () => ({
Loading: () => {
const { View, Text } = require('react-native');
return <View testID="loading"><Text>Loading...</Text></View>;
return (
<View testID="loading">
<Text>Loading...</Text>
</View>
);
},
}));

// Mock ZeroState component
// Mock ZeroState component
jest.mock('../../common/zero-state', () => ({
__esModule: true,
default: ({ heading }: { heading: string }) => {
const { View, Text } = require('react-native');
return <View><Text>{heading}</Text></View>;
return (
<View>
<Text>{heading}</Text>
</View>
);
},
}));

Expand All @@ -62,6 +70,10 @@ jest.mock('../../ui/focus-aware-status-bar', () => ({

// Mock react-native-keyboard-controller
jest.mock('react-native-keyboard-controller', () => ({
KeyboardProvider: ({ children }: any) => {
const { View } = require('react-native');
return <View testID="keyboard-provider">{children}</View>;
},
KeyboardAwareScrollView: ({ children }: any) => {
const { View } = require('react-native');
return <View testID="keyboard-aware-scroll-view">{children}</View>;
Expand All @@ -76,7 +88,11 @@ jest.mock('react-native-keyboard-controller', () => ({
jest.mock('react-native-gesture-handler', () => ({
ScrollView: ({ children, testID, ...props }: any) => {
const { ScrollView } = require('react-native');
return <ScrollView testID={testID} {...props}>{children}</ScrollView>;
return (
<ScrollView testID={testID} {...props}>
{children}
</ScrollView>
);
},
PanGestureHandler: ({ children }: any) => children,
State: {},
Expand Down Expand Up @@ -119,11 +135,7 @@ jest.mock('../../ui/button', () => ({
const { TouchableOpacity } = require('react-native');
const isButtonDisabled = disabled || isDisabled;
return (
<TouchableOpacity
onPress={isButtonDisabled ? undefined : onPress}
disabled={isButtonDisabled}
{...props}
>
<TouchableOpacity onPress={isButtonDisabled ? undefined : onPress} disabled={isButtonDisabled} {...props}>
{children}
</TouchableOpacity>
);
Expand Down Expand Up @@ -242,15 +254,19 @@ describe('CallNotesModal', () => {
},
} as any);

mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}) : {
...mockCallDetailStore,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
})
: {
...mockCallDetailStore,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}
);

mockUseAuthStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector(mockAuthStore) : mockAuthStore);
mockUseAuthStore.mockImplementation((selector: any) => (typeof selector === 'function' ? selector(mockAuthStore) : mockAuthStore));
});

it('renders correctly when open', () => {
Expand Down Expand Up @@ -285,13 +301,17 @@ describe('CallNotesModal', () => {

it('handles search input correctly', () => {
const mockSearchNotes = jest.fn(() => [mockCallDetailStore.callNotes[0]]);
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
searchNotes: mockSearchNotes,
}) : {
...mockCallDetailStore,
searchNotes: mockSearchNotes,
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
searchNotes: mockSearchNotes,
})
: {
...mockCallDetailStore,
searchNotes: mockSearchNotes,
}
);

const { getByPlaceholderText, getByText, queryByText } = render(<CallNotesModal {...mockProps} />);

Expand All @@ -304,29 +324,37 @@ describe('CallNotesModal', () => {
});

it('shows loading state correctly', () => {
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
isNotesLoading: true,
}) : {
...mockCallDetailStore,
isNotesLoading: true,
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
isNotesLoading: true,
})
: {
...mockCallDetailStore,
isNotesLoading: true,
}
);

const { getByTestId } = render(<CallNotesModal {...mockProps} />);

expect(getByTestId('loading')).toBeTruthy();
});

it('shows zero state when no notes found', () => {
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
callNotes: [],
searchNotes: jest.fn(() => []),
}) : {
...mockCallDetailStore,
callNotes: [],
searchNotes: jest.fn(() => []),
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
callNotes: [],
searchNotes: jest.fn(() => []),
})
: {
...mockCallDetailStore,
callNotes: [],
searchNotes: jest.fn(() => []),
}
);

const { getByText } = render(<CallNotesModal {...mockProps} />);

Expand All @@ -335,15 +363,19 @@ describe('CallNotesModal', () => {

it('handles adding a new note', async () => {
const mockAddNote = jest.fn();
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}) : {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
})
: {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}
);

const { getByPlaceholderText, getByText } = render(<CallNotesModal {...mockProps} />);

Expand All @@ -360,15 +392,19 @@ describe('CallNotesModal', () => {

it('disables add button when note input is empty', () => {
const mockAddNote = jest.fn();
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}) : {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
})
: {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}
);

const { getByText } = render(<CallNotesModal {...mockProps} />);

Expand All @@ -382,17 +418,21 @@ describe('CallNotesModal', () => {

it('disables add button when loading', () => {
const mockAddNote = jest.fn();
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
addNote: mockAddNote,
isNotesLoading: true,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}) : {
...mockCallDetailStore,
addNote: mockAddNote,
isNotesLoading: true,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
addNote: mockAddNote,
isNotesLoading: true,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
})
: {
...mockCallDetailStore,
addNote: mockAddNote,
isNotesLoading: true,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}
);

const { getByText, getByPlaceholderText } = render(<CallNotesModal {...mockProps} />);

Expand All @@ -417,15 +457,19 @@ describe('CallNotesModal', () => {

it('clears note input after successful submission', async () => {
const mockAddNote = jest.fn().mockResolvedValue(undefined);
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}) : {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
})
: {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}
);

const { getByPlaceholderText, getByText } = render(<CallNotesModal {...mockProps} />);

Expand All @@ -442,15 +486,19 @@ describe('CallNotesModal', () => {

it('does not add empty note when only whitespace is entered', async () => {
const mockAddNote = jest.fn();
mockUseCallDetailStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}) : {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
});
mockUseCallDetailStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
})
: {
...mockCallDetailStore,
addNote: mockAddNote,
searchNotes: jest.fn(() => mockCallDetailStore.callNotes),
}
);

const { getByPlaceholderText, getByText } = render(<CallNotesModal {...mockProps} />);

Expand All @@ -464,11 +512,15 @@ describe('CallNotesModal', () => {
});

it('handles missing user profile gracefully', () => {
mockUseAuthStore.mockImplementation((selector: any) => typeof selector === 'function' ? selector({
profile: null,
}) : {
profile: null,
});
mockUseAuthStore.mockImplementation((selector: any) =>
typeof selector === 'function'
? selector({
profile: null,
})
: {
profile: null,
}
);

const { getByText } = render(<CallNotesModal {...mockProps} />);

Expand Down
Loading
Loading