Skip to content

Message reply and card support #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philipsd6 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Message reply and card support #56

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29cca2a
Return result of /message endpoint call
philipsd6 Aug 24, 2016
784ded6
Enable sending Card notifications
philipsd6 Aug 24, 2016
7b9cc57
Add support for attach_to notification property
philipsd6 Aug 24, 2016
bac0939
Only add card,attach_to values if they are set
Sep 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hypchat/restobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,10 @@ def message(self, message):
Allows a user to send a message to a room.
"""
data = {'message': message}
self._requests.post(self.url + '/message', data=data)
resp = self._requests.post(self.url + '/message', data=data)
return Linker._obj_from_text(resp.text, self._requests)

def notification(self, message, color=None, notify=False, format=None):
def notification(self, message, card=None, color=None, notify=False, format=None, attach_to=None):
"""
Send a message to a room.
"""
Expand All @@ -156,7 +157,7 @@ def notification(self, message, color=None, notify=False, format=None):
format = 'text'
else:
format = 'html'
data = {'message': message, 'notify': notify, 'message_format': format}
data = {'message': message, 'card': card, 'notify': notify, 'message_format': format, 'attach_to': attach_to}
Copy link
Copy Markdown

@hanks hanks Dec 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this code, and if attach_to is None, there will be error like below:

hypchat.requests.HttpBadRequest: {
  "error": {
    "code": 400,
    "description": "Value {value!r} is not of type {expected_type!r}",
    "expected_type": "string",
    "field": "attach_to",
    "message": "Value None for field 'attach_to' is not of type 'string'",
    "type": "Bad Request",
    "validation": "type",
    "value": null
  }

Seems to use None check will be better:

if card:
    data['card'] = card
if attach_to:
    data['attach_to'] = attach_to

if color:
data['color'] = color
self._requests.post(self.url + '/notification', data=data)
Expand Down