fix(worker): fail fast on non-retryable exceptions (DEV-52)#10
Merged
Conversation
- Only RetryableException re-queues; other errors fail the job/asset immediately - Stop burning the full retry budget on permanent failures (bad type, corrupt file) - Add tests for retryable requeue vs non-retryable fail-fast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DEV-52. Follow-up to DEV-34.
The consumer retried every exception up to
max_retries, so a permanent failure (unknown asset type, corrupt file, decode error) burned the whole retry budget before the asset was markedfailed.Fix
Branch on exception type in
_handle_job's except:RetryableExceptionkeeps the existing retry path (jobs=pendingbelow cap); any other exception fails immediately (jobs=failed+assets=failed) regardless of remaining attempts.Transient infra errors (DB/Redis/storage timeouts) are not auto-retried unless wrapped in
RetryableException— noted as a possible future refinement, kept out of scope here.🤖 Generated with Claude Code