fix(worker): let consumer own asset state on failure (DEV-34)#6
Merged
Merged
Conversation
- Stop the processor stamping assets.status=failed on every exception - Retryable failures no longer leave the asset stuck failed mid-retry - Consumer already marks failed only past the retry cap, ready on success - Add regression test asserting no failed-status write on processing error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DEV-34.
processor.py's genericexceptwroteassets.status=failedon every exception — includingRetryableException— so a retryable failure flipped the asset tofailedwhile the job was still pending/retrying. A polling client saw a permanently-broken upload until (if) a later attempt succeeded.Fix
except; keep logging +raise_handle_job) is now the single owner of asset state:failedonly past the retry cap,readyon success, untouched during retries (asset staysprocessing)Note
Verified in an isolated venv — the local Poetry toolchain is currently broken (orphaned 3.12 interpreter after a homebrew upgrade).
🤖 Generated with Claude Code