fix(worker): run stuck-job recovery on a fixed cadence (DEV-35)#7
Merged
Merged
Conversation
- Time-gate recovery via _maybe_recover and call it every consume() - Recover regardless of load instead of only on the idle path - Stop in_progress jobs from a crashed worker getting stuck under load - Sweep leftovers at startup (_last_recovery starts at 0) - Add tests for the load-path firing and the interval gate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DEV-35.
Recovery (
_recover_stuck_pending) was only called on the idle path ofconsume()(whenxreadgroupreturned nothing). Under sustained load the worker never idles, so the sole mechanism for re-queueing jobs leftin_progressby a crashed worker never fired — precisely when stuck jobs are most likely.Fix
_maybe_recover()— a time-gated wrapper (_recovery_interval = 120s, matching the 2-min staleness threshold in the recovery query)consume(), decoupled from message availability; remove the idle-path-only call_last_recoverystarts at 0 so leftovers from a prior crash are swept on the first poll🤖 Generated with Claude Code