fix(api): hardening batch — recovery order, request IDs, MIME allowlist#9
Merged
Conversation
- Move RecoveryMiddleware outermost so panics in inner middleware are caught (DEV-36) - Replace time-based request-ID chars with math/rand/v2 (unbiased, no collisions) (DEV-37) - Centralise supported MIME types in repository.SupportedMIMETypes; handler gates against it (DEV-38) - Add tests for request-ID generation and the MIME gate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DEV-36, DEV-37, DEV-38.
Three independent Go API correctness fixes batched into one PR.
DEV-36 — RecoveryMiddleware ordering
Moved
RecoveryMiddlewareto the outermost app-level position (after RequestID/RealIP, before cors/logger) so panics in any inner middleware are caught and returned as 500 instead of crashing the process. It takes the base logger directly, so it doesn't depend on LoggerMiddleware running first.DEV-37 — biased fallback request IDs
randomStringusedtime.Now().UnixNano() % lenper char → identical chars within a nanosecond, collisions under load. Replaced withmath/rand/v2(concurrency-safe, unbiased). Test asserts charset, length, and 1000-call uniqueness.DEV-38 — duplicate MIME allowlists
Replaced the handler's private
allowedMIMETypeswith a single source of truthrepository.SupportedMIMETypes(+IsSupportedMIMEType). The broadToAssetTypeFromMimeTypeclassifier stays for stored typing. Test pins the gate set.🤖 Generated with Claude Code