fix bug low onchain balance results in infinite loading#2429
Open
jerryfletcher21 wants to merge 1 commit intoRoboSats:mainfrom
Open
fix bug low onchain balance results in infinite loading#2429jerryfletcher21 wants to merge 1 commit intoRoboSats:mainfrom
jerryfletcher21 wants to merge 1 commit intoRoboSats:mainfrom
Conversation
There is a bug that happens when the coordinator has low onchain balance that results in an infinite loading on the frontend when an order bigger than the coordinator onchain balance is taken. This happens because `create_onchain_payment` returns `False` when `preliminary_amount > available_onchain` before adding `suggested_mining_fee_rate` to `onchain_payment`. So `suggested_mining_fee_rate` was called without checking if `create_onchain_payment` returned `True`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug that happens when the coordinator has low onchain balance that results in an infinite loading on the frontend when an order bigger than the coordinator onchain balance is taken.
This happens because
create_onchain_paymentreturnsFalsewhenpreliminary_amount > available_onchainbefore addingsuggested_mining_fee_ratetoonchain_payment.So
suggested_mining_fee_ratewas called without checking ifcreate_onchain_paymentreturnedTrue