Skip to content

Patch rviz and image_view shutdown on macOS#247

Open
Tobias-Fischer wants to merge 1 commit into
mainfrom
codex/macos-rviz-image-view-patches
Open

Patch rviz and image_view shutdown on macOS#247
Tobias-Fischer wants to merge 1 commit into
mainfrom
codex/macos-rviz-image-view-patches

Conversation

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Summary

Adds macOS-only RoboStack patches for rviz and image_pipeline shutdown issues:

  • patch rviz2 teardown ordering to avoid static/global shutdown crashes on macOS
  • patch rviz_common visualization teardown so rendering stops cleanly before destruction
  • patch rviz_default_plugins Camera/Image display unsubscribe and listener teardown paths
  • patch image_view so OpenCV HighGUI runs on the macOS main thread while ROS spins in the background
  • bump build numbers for rviz2, rviz_common, rviz_default_plugins, and image_view to 19

The patches use the .osx.patch suffix so Vinca only wires them into macOS-generated recipes.

Validation

Ran the focused patch application check:

python check_patches_clean_apply.py \
  --recipe ros-jazzy-rviz2 \
  --recipe ros-jazzy-rviz-common \
  --recipe ros-jazzy-rviz-default-plugins \
  --recipe ros-jazzy-image-view

Result:

Total recipes tested: 4
Passed: 4
Failed: 0
All patches applied cleanly.

@Tobias-Fischer

Copy link
Copy Markdown
Contributor Author

Hi @traversaro – I ran into heaps of issues when playing around with https://www.linkedin.com/feed/update/urn:li:activity:7482615896847581184 – those are the fixes that were required for rviz2 and image_view to work nicely on osx. Could you please take a look?

@Tobias-Fischer
Tobias-Fischer marked this pull request as ready for review July 14, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant