Patch rviz and image_view shutdown on macOS#247
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi @traversaro – I ran into heaps of issues when playing around with https://www.linkedin.com/feed/update/urn:li:activity:7482615896847581184 – those are the fixes that were required for rviz2 and image_view to work nicely on osx. Could you please take a look? |
Tobias-Fischer
marked this pull request as ready for review
July 14, 2026 03:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds macOS-only RoboStack patches for rviz and image_pipeline shutdown issues:
rviz2teardown ordering to avoid static/global shutdown crashes on macOSrviz_commonvisualization teardown so rendering stops cleanly before destructionrviz_default_pluginsCamera/Image display unsubscribe and listener teardown pathsimage_viewso OpenCV HighGUI runs on the macOS main thread while ROS spins in the backgroundrviz2,rviz_common,rviz_default_plugins, andimage_viewto19The patches use the
.osx.patchsuffix so Vinca only wires them into macOS-generated recipes.Validation
Ran the focused patch application check:
Result: