Fix asset cache busting on GitHub Pages builds#9
Merged
Conversation
Commit _data/assets.yml to the repo and validate it in CI, since Pages runs its own Jekyll build and never sees files generated only in Actions.
Add a CI job that regenerates _data/assets.yml and pushes it to the PR branch when CSS or JS changes, so merges already include the correct cache-busting hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #8 generated
_data/assets.ymlonly inside the GitHub Actions runner. GitHub Pages builds the site separately from the repo, and the file was gitignored — sosite.data.assetswas empty and the layout fell back to?v=dev.Fix
_data/assets.ymlwith the current CSS/JS content hashasset_version.py --check(same pattern as WebP derivatives)site.github.build_revisionbeforedevif the data file is ever missingTest plan
?v=e7eb82e9(or current hash) on CSS/JS URLs, notdev