Merge pull request #2334 from HusseinElFeky/language-change-fix

[FIX] Fixes issues and memory leaks after changing language

Author: philipbrito

app/src/main/java/chat/rocket/android/directory/presentation/DirectoryPresenter.kt

@@ -136,7 +136,7 @@ class DirectoryPresenter @Inject constructor(
         }
     }
 
-    fun tiDirectMessage(username: String, name: String) {
+    fun toDirectMessage(username: String, name: String) {
         launchUI(strategy) {
             try {
                 view.showLoading()

app/src/main/java/chat/rocket/android/directory/ui/DirectoryFragment.kt

@@ -49,10 +49,10 @@ class DirectoryFragment : Fragment(), DirectoryView {
             presenter.toChannel(channelId, channelName)
         }
         override fun onUserSelected(username: String, name: String) {
-            presenter.tiDirectMessage(username, name)
+            presenter.toDirectMessage(username, name)
         }
         override fun onGlobalUserSelected(username: String, name: String) {
-            presenter.tiDirectMessage(username, name)
+            presenter.toDirectMessage(username, name)
         }
     })
     private val hashtagDrawable by lazy {

app/src/main/java/chat/rocket/android/main/presentation/MainNavigator.kt

@@ -1,5 +1,6 @@
 package chat.rocket.android.main.presentation
 
+import android.content.Intent
 import chat.rocket.android.R
 import chat.rocket.android.authentication.ui.newServerIntent
 import chat.rocket.android.chatroom.ui.chatRoomIntent
@@ -100,4 +101,9 @@ class MainNavigator(internal val activity: MainActivity) {
     fun toServerScreen() {
         activity.startActivity(activity.newServerIntent())
     }
+
+    fun recreateActivity() {
+        activity.startActivity(Intent(activity, MainActivity::class.java))
+        activity.finish()
+    }
 }

app/src/main/java/chat/rocket/android/settings/presentation/SettingsPresenter.kt

@@ -148,4 +148,6 @@ class SettingsPresenter @Inject constructor(
 
     fun toLicense(licenseUrl: String, licenseTitle: String) =
         navigator.toLicense(licenseUrl, licenseTitle)
+
+    fun recreateActivity() = navigator.recreateActivity()
 }

app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt

@@ -132,7 +132,7 @@ class SettingsFragment : Fragment(), SettingsView, AppLanguageView {
 
     override fun updateLanguage(language: String, country: String?) {
         presenter.saveLocale(language, country)
-        activity?.recreate()
+        presenter.recreateActivity()
     }
 
     override fun invalidateToken(token: String) = invalidateFirebaseToken(token)