Skip to content

Fix goal progress verification#2

Merged
Rohith31-WD merged 1 commit into
mainfrom
codex/fix-goal-progress-verification
May 31, 2026
Merged

Fix goal progress verification#2
Rohith31-WD merged 1 commit into
mainfrom
codex/fix-goal-progress-verification

Conversation

@Rohith31-WD
Copy link
Copy Markdown
Owner

Summary

  • Reject client-supplied progress updates for GitHub-synced goals (commits and prs)
  • Keep manual progress updates available for non-GitHub goals
  • Add regression tests for synced-goal PATCH behavior

Root cause

The PATCH endpoint validated that current was numeric and within target bounds, but it trusted the client as the source of truth for goals whose progress should come from GitHub activity.

Validation

  • npm exec -- tsc --noEmit
  • npm exec -- vitest run test/goals-patch-progress.test.ts could not start in this sandbox because the local runner's esbuild subprocess was blocked with spawn EPERM.

Fixes Priyanshu-byte-coder#1753

@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Rohith31-WD — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Rohith31-WD Rohith31-WD changed the title [codex] Fix goal progress verification Fix goal progress verification May 31, 2026
@Rohith31-WD Rohith31-WD marked this pull request as ready for review May 31, 2026 11:24
@Rohith31-WD Rohith31-WD merged commit a83eb73 into main May 31, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Merged! Thanks for contributing to DevTrack.

If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers.

Keep an eye on open issues for your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Goal progress can be arbitrarily modified through the PATCH endpoint without verification against actual GitHub activity

1 participant