[Fix] Prevent stale PR review actions#739
Merged
Merged
Conversation
Contributor
daniel-lxs
marked this pull request as draft
July 23, 2026 20:48
daniel-lxs
force-pushed
the
fix/pr-review-offer-races
branch
from
July 23, 2026 20:56
8dd06e4 to
3cbab5b
Compare
daniel-lxs
marked this pull request as ready for review
July 23, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three defects in the PR review offer plumbing on develop:
attachPendingPrReviewActionMessageused GET-then-SET, so an offer claimed by a typed reply in between was silently recreated with live buttons that dispatch the superseded follow-up. The message id is now attached in a single atomic Lua script (KEEPTTL) that no-ops when the record is gone.claimPendingPrReviewActionsForThreadread and deleted the conversation index in separate operations, so offers indexed concurrently were dropped unclaimed and could never be retired by a later reply. The read, clear, and claim now run in one atomic script.Includes mocked-Redis tests for both scripts and a DB-backed test for the host inheritance guard.
🤖 Generated with Claude Code