Apply Rule of Zero to old-style uncopyable classes in core/ and protocols/

source/src/core/chemical/rotamers/RotamerLibrarySpecificationFactory.hh

@@ -57,8 +57,6 @@ private:
 
 private:
 	RotamerLibrarySpecificationFactory();
-	RotamerLibrarySpecificationFactory( RotamerLibrarySpecificationFactory const & ); // unimplemented
-	RotamerLibrarySpecificationFactory const & operator = ( RotamerLibrarySpecificationFactory const & ); // unimplemented
 
 private:
 	typedef std::map< std::string, RotamerLibrarySpecificationCreatorOP > CreatorMap;

source/src/core/pack/dunbrack/RotamerLibrary.hh

@@ -366,9 +366,6 @@ private:
 	void
 	initialize_from_options( utility::options::OptionCollection const & options );
 
-	RotamerLibrary( RotamerLibrary const & ); // unimplemented
-	RotamerLibrary const & operator = ( RotamerLibrary const & ); // unimplemented
-
 private:
 
 	//////////////////////////

source/src/core/pack/dunbrack/cenrot/CenrotLibrary.hh

@@ -79,8 +79,6 @@ private:
 private:
 
 	CenrotLibrary();
-	CenrotLibrary( CenrotLibrary const & ); // unimplemented
-	CenrotLibrary const & operator = ( CenrotLibrary const & ); // unimplemented
 
 private:
 

source/src/core/pack/interaction_graph/DensePDInteractionGraph.hh

@@ -174,10 +174,10 @@ private:
 
 	bool alternate_state_is_being_considered_;
 
-	//no default constructor, uncopyable
-	DensePDNode();
-	DensePDNode( DensePDNode const & );
-	DensePDNode & operator = ( DensePDNode const & );
+public:
+	DensePDNode() = delete;
+	DensePDNode( DensePDNode const & ) = delete;
+	DensePDNode & operator = ( DensePDNode const & ) = delete;
 };
 
 class DensePDEdge : public PrecomputedPairEnergiesEdge
@@ -261,10 +261,10 @@ private:
 	core::PackerEnergy curr_state_energy_;
 	bool energies_updated_since_last_prep_for_simA_;
 
-	//no default constructor, uncopyable
-	DensePDEdge();
-	DensePDEdge( DensePDEdge const & );
-	DensePDEdge & operator = ( DensePDEdge const & );
+public:
+	DensePDEdge() = delete;
+	DensePDEdge( DensePDEdge const & ) = delete;
+	DensePDEdge & operator = ( DensePDEdge const & ) = delete;
 };
 
 class DensePDInteractionGraph : public PrecomputedPairEnergiesInteractionGraph
@@ -372,10 +372,10 @@ private:
 
 	static const int COMMIT_LIMIT_BETWEEN_UPDATES = 1024; // 2^10
 
-	//no default constructor, uncopyable
-	DensePDInteractionGraph();
-	DensePDInteractionGraph( DensePDInteractionGraph const & );
-	DensePDInteractionGraph & operator = ( DensePDInteractionGraph const & );
+public:
+	DensePDInteractionGraph() = delete;
+	DensePDInteractionGraph( DensePDInteractionGraph const & ) = delete;
+	DensePDInteractionGraph & operator = ( DensePDInteractionGraph const & ) = delete;
 };
 
 inline

source/src/core/pack/interaction_graph/DoubleDensePDInteractionGraph.hh

@@ -125,10 +125,10 @@ private:
 
 	bool alternate_state_is_being_considered_;
 
-	//no default constructor, uncopyable
-	DoubleDensePDNode();
-	DoubleDensePDNode( DoubleDensePDNode const & );
-	DoubleDensePDNode & operator = ( DoubleDensePDNode const & );
+public:
+	DoubleDensePDNode() = delete;
+	DoubleDensePDNode( DoubleDensePDNode const & ) = delete;
+	DoubleDensePDNode & operator = ( DoubleDensePDNode const & ) = delete;
 };
 
 class DoubleDensePDEdge : public PrecomputedPairEnergiesEdge
@@ -200,10 +200,10 @@ private:
 	core::PackerEnergy curr_state_energy_;
 	bool energies_updated_since_last_prep_for_simA_;
 
-	//no default constructor, uncopyable
-	DoubleDensePDEdge();
-	DoubleDensePDEdge( DoubleDensePDEdge const & );
-	DoubleDensePDEdge & operator = ( DoubleDensePDEdge const & );
+public:
+	DoubleDensePDEdge() = delete;
+	DoubleDensePDEdge( DoubleDensePDEdge const & ) = delete;
+	DoubleDensePDEdge & operator = ( DoubleDensePDEdge const & ) = delete;
 };
 
 class DoubleDensePDInteractionGraph : public PrecomputedPairEnergiesInteractionGraph
@@ -273,10 +273,10 @@ private:
 
 	static const int COMMIT_LIMIT_BETWEEN_UPDATES = 1024; // 2^10
 
-	//no default constructor, uncopyable
-	DoubleDensePDInteractionGraph();
-	DoubleDensePDInteractionGraph( DoubleDensePDInteractionGraph const & );
-	DoubleDensePDInteractionGraph & operator = ( DoubleDensePDInteractionGraph const & );
+public:
+	DoubleDensePDInteractionGraph() = delete;
+	DoubleDensePDInteractionGraph( DoubleDensePDInteractionGraph const & ) = delete;
+	DoubleDensePDInteractionGraph & operator = ( DoubleDensePDInteractionGraph const & ) = delete;
 };
 
 /// @brief returns the change in energy that would be induced by switching this node

source/src/core/pack/interaction_graph/DoubleLazyInteractionGraph.cc

@@ -62,8 +62,7 @@ DoubleLazyNode::DoubleLazyNode(
 	alternate_state_( 0 ),
 	alternate_state_one_body_energy_( 0 ),
 	alternate_state_total_energy_( 0 ),
-	alternate_state_is_being_considered_( false ),
-	procrastinated_( false )
+	alternate_state_is_being_considered_( false )
 {
 }
 

source/src/core/pack/interaction_graph/DoubleLazyInteractionGraph.hh

@@ -176,12 +176,11 @@ private:
 	std::vector< core::PackerEnergy > alternate_state_two_body_energies_;
 
 	bool alternate_state_is_being_considered_;
-	bool procrastinated_;
 
-	//no default constructor, uncopyable
-	DoubleLazyNode();
-	DoubleLazyNode( DoubleLazyNode const & );
-	DoubleLazyNode & operator = ( DoubleLazyNode const & );
+public:
+	DoubleLazyNode() = delete;
+	DoubleLazyNode( DoubleLazyNode const & ) = delete;
+	DoubleLazyNode & operator = ( DoubleLazyNode const & ) = delete;
 
 };
 
@@ -380,10 +379,10 @@ private:
 	// prepare_for_simulated_annealing
 	int edge_index_;
 
-	//no default constructor, uncopyable
-	DoubleLazyEdge();
-	DoubleLazyEdge( DoubleLazyEdge const & );
-	DoubleLazyEdge & operator = ( DoubleLazyEdge const & );
+public:
+	DoubleLazyEdge() = delete;
+	DoubleLazyEdge( DoubleLazyEdge const & ) = delete;
+	DoubleLazyEdge & operator = ( DoubleLazyEdge const & ) = delete;
 
 };
 
@@ -527,10 +526,10 @@ private:
 	utility::vector0< DoubleLazyEdge * > dlazy_edge_vector_;
 	mutable InPlaceIntListOP aa_submatrix_history_list_;
 
-	//no default constructor, uncopyable
-	DoubleLazyInteractionGraph();
-	DoubleLazyInteractionGraph( DoubleLazyInteractionGraph const & );
-	DoubleLazyInteractionGraph & operator = ( DoubleLazyInteractionGraph const & );
+public:
+	DoubleLazyInteractionGraph() = delete;
+	DoubleLazyInteractionGraph( DoubleLazyInteractionGraph const & ) = delete;
+	DoubleLazyInteractionGraph & operator = ( DoubleLazyInteractionGraph const & ) = delete;
 
 };
 

source/src/core/pack/interaction_graph/FASTERInteractionGraph.hh

@@ -189,10 +189,10 @@ private:
 	std::vector< bool > neighbor_relaxed_in_sBR_;
 	std::vector< core::PackerEnergy > perturbed_two_body_energies_;
 
-	//no default constructor, uncopyable
-	FASTERNode();
-	FASTERNode( FASTERNode const & );
-	FASTERNode & operator = ( FASTERNode const & );
+public:
+	FASTERNode() = delete;
+	FASTERNode( FASTERNode const & ) = delete;
+	FASTERNode & operator = ( FASTERNode const & ) = delete;
 };
 
 class FASTEREdge : public PrecomputedPairEnergiesEdge
@@ -313,10 +313,10 @@ private:
 
 private:
 	// Unimplemented functions
-	//no default constructor, uncopyable
-	FASTEREdge();
-	FASTEREdge( FASTEREdge const & );
-	FASTEREdge & operator = ( FASTEREdge const & );
+public:
+	FASTEREdge() = delete;
+	FASTEREdge( FASTEREdge const & ) = delete;
+	FASTEREdge & operator = ( FASTEREdge const & ) = delete;
 };
 
 class FASTERInteractionGraph : public PrecomputedPairEnergiesInteractionGraph
@@ -432,10 +432,10 @@ private:
 
 	static const int COMMIT_LIMIT_BETWEEN_UPDATES = 1024; // 2^10
 
-	//no default constructor, uncopyable
-	FASTERInteractionGraph();
-	FASTERInteractionGraph( FASTERInteractionGraph const & );
-	FASTERInteractionGraph & operator = ( FASTERInteractionGraph const & );
+public:
+	FASTERInteractionGraph() = delete;
+	FASTERInteractionGraph( FASTERInteractionGraph const & ) = delete;
+	FASTERInteractionGraph & operator = ( FASTERInteractionGraph const & ) = delete;
 };
 
 inline

source/src/core/pack/interaction_graph/InteractionGraphBase.hh

@@ -182,10 +182,10 @@ private:
 	bool edge_vector_up_to_date_;
 	InteractionGraphBase* owner_;
 
-	//no default constructor, uncopyable
-	NodeBase();
-	NodeBase( NodeBase const & );
-	NodeBase & operator = ( NodeBase & );
+public:
+	NodeBase() = delete;
+	NodeBase( NodeBase const & ) = delete;
+	NodeBase & operator = ( NodeBase const & ) = delete;
 };
 
 class EdgeBase
@@ -311,10 +311,10 @@ private:
 	bool marked_for_deletion_ = false;
 
 
-	//no default constructor, uncopyable
-	EdgeBase();
-	EdgeBase( EdgeBase const & );
-	EdgeBase & operator = ( EdgeBase & );
+public:
+	EdgeBase() = delete;
+	EdgeBase( EdgeBase const & ) = delete;
+	EdgeBase & operator = ( EdgeBase const & ) = delete;
 
 };
 
@@ -550,10 +550,10 @@ private:
 	ObjexxFCL::FArray2D_bool energy_sum_group_membership_;
 	ObjexxFCL::FArray1D_int component_membership_;
 
-	//no default constructor, uncopyable
-	InteractionGraphBase();
-	InteractionGraphBase( InteractionGraphBase const &);
-	InteractionGraphBase & operator = (InteractionGraphBase const & );
+public:
+	InteractionGraphBase() = delete;
+	InteractionGraphBase( InteractionGraphBase const & ) = delete;
+	InteractionGraphBase & operator = ( InteractionGraphBase const & ) = delete;
 };
 
 } //end namespace interaction_graph

source/src/core/pack/interaction_graph/LazyInteractionGraph.cc

@@ -57,8 +57,7 @@ LazyNode::LazyNode(
 	alternate_state_( 0 ),
 	alternate_state_one_body_energy_( 0 ),
 	alternate_state_total_energy_( 0 ),
-	alternate_state_is_being_considered_( false ),
-	procrastinated_( false )
+	alternate_state_is_being_considered_( false )
 {
 }
 

source/src/core/pack/interaction_graph/LazyInteractionGraph.hh

@@ -167,12 +167,11 @@ private:
 	std::vector< core::PackerEnergy > alternate_state_two_body_energies_;
 
 	bool alternate_state_is_being_considered_;
-	bool procrastinated_;
 
-	//no default constructor, uncopyable
-	LazyNode();
-	LazyNode( LazyNode const & );
-	LazyNode & operator = ( LazyNode const & );
+public:
+	LazyNode() = delete;
+	LazyNode( LazyNode const & ) = delete;
+	LazyNode & operator = ( LazyNode const & ) = delete;
 
 };
 
@@ -333,10 +332,10 @@ private:
 	bool partial_state_assignment_;
 	bool ran_annealing_since_pair_energy_table_cleared_;
 
-	//no default constructor, uncopyable
-	LazyEdge();
-	LazyEdge( LazyEdge const & );
-	LazyEdge & operator = ( LazyEdge const & );
+public:
+	LazyEdge() = delete;
+	LazyEdge( LazyEdge const & ) = delete;
+	LazyEdge & operator = ( LazyEdge const & ) = delete;
 
 };
 
@@ -418,18 +417,17 @@ protected:
 	}
 
 private:
-	int num_aa_types_;
 	int num_commits_since_last_update_;
 	core::PackerEnergy total_energy_current_state_assignment_;
 	core::PackerEnergy total_energy_alternate_state_assignment_;
 	int node_considering_alt_state_;
 
 	static const int COMMIT_LIMIT_BETWEEN_UPDATES = 1024; // 2^10
 
-	//no default constructor, uncopyable
-	LazyInteractionGraph();
-	LazyInteractionGraph( LazyInteractionGraph const & );
-	LazyInteractionGraph & operator = ( LazyInteractionGraph const & );
+public:
+	LazyInteractionGraph() = delete;
+	LazyInteractionGraph( LazyInteractionGraph const & ) = delete;
+	LazyInteractionGraph & operator = ( LazyInteractionGraph const & ) = delete;
 
 };
 

source/src/core/pack/interaction_graph/LinearMemoryInteractionGraph.hh

@@ -360,10 +360,10 @@ private:
 	bool partial_state_assignment_;
 	bool preped_for_sim_annealing_;
 
-	//no default constructor, uncopyable
-	LinearMemEdge();
-	LinearMemEdge( LinearMemEdge const & );
-	LinearMemEdge & operator = ( LinearMemEdge const & );
+public:
+	LinearMemEdge() = delete;
+	LinearMemEdge( LinearMemEdge const & ) = delete;
+	LinearMemEdge & operator = ( LinearMemEdge const & ) = delete;
 
 };
 
@@ -435,10 +435,10 @@ private:
 
 	static const int COMMIT_LIMIT_BETWEEN_UPDATES = 1024; // 2^10
 
-	//no default constructor, uncopyable
-	LinearMemoryInteractionGraph();
-	LinearMemoryInteractionGraph( LinearMemoryInteractionGraph const & );
-	LinearMemoryInteractionGraph & operator = ( LinearMemoryInteractionGraph const & );
+public:
+	LinearMemoryInteractionGraph() = delete;
+	LinearMemoryInteractionGraph( LinearMemoryInteractionGraph const & ) = delete;
+	LinearMemoryInteractionGraph & operator = ( LinearMemoryInteractionGraph const & ) = delete;
 };