This repository was archived by the owner on Jul 14, 2026. It is now read-only.
💄 Create custom error messages for scan failure#308
Merged
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ecoscan_app/hooks/useAnalyzeProduct.ts`:
- Around line 88-90: Update the error handling in useAnalyzeProduct to preserve
the upstream HTTP response status on a typed error from apiClient, then classify
product-not-found responses by checking status 404 rather than matching
String(err). Keep unrelated messages from being treated as not-found, and add
tests covering a genuine 404 whose message omits the status and a non-404
message containing “404”.
- Around line 91-95: Update the catch handling in useAnalyzeProduct so
cancelAnalysis and handleStreamError cancellation/abort failures are rethrown
unchanged, preserving their user-facing behavior. Only convert unexpected
failures to the generic “Analyse fehlgeschlagen…” error, using the established
typed error codes or error types rather than matching message text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6770f5c8-8dfc-439c-8861-4f9afba5a2b2
📒 Files selected for processing (1)
ecoscan_app/hooks/useAnalyzeProduct.ts
IamPekka058
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create custom, user readable error messages for scan failure instead of displaying the internal errors.