✨ Delete tasks#199
Merged
Merged
Conversation
Closed
# Conflicts: # lib/ui/task_details/task_details_view.dart
Friedinger
marked this pull request as draft
September 1, 2025 19:15
Member
Author
|
Deleting tasks currently fails, but I think that it is a problem on |
Member
Author
Was fixed in RubberDuckCrew/github_flutter#26 |
Friedinger
marked this pull request as ready for review
September 6, 2025 21:02
IamPekka058
marked this pull request as draft
September 7, 2025 09:37
Friedinger
marked this pull request as ready for review
September 7, 2025 11:19
|
📦 Build Artifacts |
2 tasks
IamPekka058
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor to the task details view, improving separation of concerns and user interaction with tasks. The main changes include extracting view logic into a dedicated
TaskDetailsViewModel, adding support for deleting tasks both locally and remotely, and enhancing the app bar to support menu actions.Task deletion and management improvements:
deleteRemotemethod to theTaskmodel to support deleting issues from the remote repository, with logging for success or failure.deleteTaskmethod toTaskHandlerthat removes a task locally and remotely, and notifies listeners of changes.UI and view model refactor:
TaskDetailsViewModelclass, moving editing, deletion, and state-changing actions out of the view and into the view model. This improves code organization and maintainability. [1] [2]TaskDetailsViewto use the new view model, replacing direct logic with calls to view model methods, and moved floating action buttons and menu actions to use the view model. [1] [2] [3]App bar enhancements:
NormalAppBarto accept a list of menu items, enabling popup menu actions such as task deletion from the app bar. [1] [2]Minor updates:
backVisibleproperty inNormalAppBar. [1] [2]