Skip to content

✨ Delete tasks#199

Merged
Friedinger merged 16 commits into
mainfrom
feature/delete-tasks
Sep 7, 2025
Merged

✨ Delete tasks#199
Friedinger merged 16 commits into
mainfrom
feature/delete-tasks

Conversation

@Friedinger

@Friedinger Friedinger commented Aug 17, 2025

Copy link
Copy Markdown
Member

This pull request introduces a major refactor to the task details view, improving separation of concerns and user interaction with tasks. The main changes include extracting view logic into a dedicated TaskDetailsViewModel, adding support for deleting tasks both locally and remotely, and enhancing the app bar to support menu actions.

Task deletion and management improvements:

  • Added a deleteRemote method to the Task model to support deleting issues from the remote repository, with logging for success or failure.
  • Added a deleteTask method to TaskHandler that removes a task locally and remotely, and notifies listeners of changes.

UI and view model refactor:

  • Extracted task details logic into a new TaskDetailsViewModel class, moving editing, deletion, and state-changing actions out of the view and into the view model. This improves code organization and maintainability. [1] [2]
  • Updated TaskDetailsView to use the new view model, replacing direct logic with calls to view model methods, and moved floating action buttons and menu actions to use the view model. [1] [2] [3]

App bar enhancements:

  • Modified NormalAppBar to accept a list of menu items, enabling popup menu actions such as task deletion from the app bar. [1] [2]

Minor updates:

  • Cleaned up imports and improved type safety for the backVisible property in NormalAppBar. [1] [2]
  • Updated documentation and comments for improved clarity.

@Friedinger Friedinger added the ✨ Enhancement New feature or request label Aug 17, 2025
@Friedinger Friedinger linked an issue Aug 17, 2025 that may be closed by this pull request
@Friedinger
Friedinger marked this pull request as ready for review August 17, 2025 17:14
@Friedinger
Friedinger requested a review from IamPekka058 August 17, 2025 17:16
@IamPekka058 IamPekka058 added the ⚗️ Request Build Requests a build of the project label Aug 18, 2025
@github-actions github-actions Bot removed the ⚗️ Request Build Requests a build of the project label Aug 18, 2025
@Friedinger
Friedinger marked this pull request as draft September 1, 2025 19:15
@Friedinger

Copy link
Copy Markdown
Member Author

Deleting tasks currently fails, but I think that it is a problem on github_flutter's side and not here

@Friedinger

Friedinger commented Sep 6, 2025

Copy link
Copy Markdown
Member Author

Deleting tasks currently fails, but I think that it is a problem on github_flutter's side and not here

Was fixed in RubberDuckCrew/github_flutter#26

@Friedinger
Friedinger marked this pull request as ready for review September 6, 2025 21:02
@Friedinger Friedinger added the ⚗️ Request Build Requests a build of the project label Sep 6, 2025
@github-actions github-actions Bot removed the ⚗️ Request Build Requests a build of the project label Sep 6, 2025
@IamPekka058
IamPekka058 marked this pull request as draft September 7, 2025 09:37
@Friedinger Friedinger added the ⚗️ Request Build Requests a build of the project label Sep 7, 2025
@Friedinger
Friedinger marked this pull request as ready for review September 7, 2025 11:19
@github-actions github-actions Bot removed the ⚗️ Request Build Requests a build of the project label Sep 7, 2025
@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

@Friedinger Friedinger linked an issue Sep 7, 2025 that may be closed by this pull request
2 tasks
@Friedinger
Friedinger merged commit 42f15ef into main Sep 7, 2025
15 checks passed
@Friedinger
Friedinger deleted the feature/delete-tasks branch September 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Confirm Deletion Popup for Tasks ✨ Delete todos

4 participants