Skip to content

Dependency updates: only the dispatched build decides whether an update failed - #50

Merged
EaZyCheaZ merged 1 commit into
devfrom
p1-dependency-updates-approval
Oct 25, 2026
Merged

EaZyCheaZ merged 1 commit into
devfrom
p1-dependency-updates-approval

Conversation

@EaZyCheaZ

Copy link
Copy Markdown
Contributor

Part of task 4f. #48 (web app patch and minor) was held as "build failed" while its build was still running: the workflow's push also queued pull request runs that wait for approval (action_required), and the check counted those as failures.

  • The failure check now looks only at the workflow_dispatch build the workflow starts, and treats only failure, timed out and startup failure as failed.
  • Self-test 17 of 17. Changelog 0.4.5, heading only.

#48 already carries 0.4.5 from the workflow; once this merges it is re-versioned above dev (0.4.6) on its next run.

…version 0.4.5)

The workflow's own push queued pull request runs that wait for an approval (action_required), and the update step
counted them as a failed build and held #48 for review. Only the build it starts by dispatch counts now.
@EaZyCheaZ
EaZyCheaZ merged commit 52a66d2 into dev Oct 25, 2026
23 checks passed
@EaZyCheaZ
EaZyCheaZ deleted the p1-dependency-updates-approval branch October 25, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant