fix: green full-suite after main product drift by gsxdsm · Pull Request #2275 · Runfusion/Fusion

gsxdsm · 2026-07-17T18:45:47Z

Summary

Follow-up after #2266: full suite on latest main still failed on i18n parity and engine product-drift tests (duplicate flagging, mission validator signature, worktree path reservation, pi ModelRuntime, assigned-agent PG layer).

Changes

i18n: add listView/tasks.statusReplan and mobile-nav settings keys to es/fr/ko/zh-CN/zh-TW
triage: opt-in triageDuplicateResolution: "delete" coverage + default prompt/flag path; stub recordActivity
MCP PR response: stub getTask for merger model resolution
pi-layers: mock ModelRuntime.create (FN-8142)
assigned-agent: stub getAsyncLayer for authoritative AgentStore fallback
mission validation: startValidatorRun(..., taskId) + runValidation { result, inspection } shape
worktree acquisition: real temp roots for path reservation; probe-aware worktrunk failure fixture
useBlockerFanout: read MAX_AUTO_MERGE_RETRIES from self-healing-constants.ts (wave-8 peel)

Test plan

Summary by CodeRabbit

Localization
- Added “Replan”/replanning status labels across Spanish, French, Korean, Simplified Chinese, and Traditional Chinese.
- Completed settings mobile navigation translations, including primary items controls and reordering options.
Tests
- Expanded coverage for validation recovery and task forwarding behavior.
- Improved duplicate-resolution scenarios (including activity recording and lineage deletion behavior).
- Increased test reliability for worktree acquisition by using temporary filesystem roots.

Restore i18n key parity (Replan + mobile nav strings), update engine test mocks for getTask/recordActivity/getAsyncLayer/ModelRuntime, align DUPLICATE marker and mission validator expectations with current product APIs, and make worktree path-reservation tests use real temp roots.

coderabbitai · 2026-07-17T18:46:39Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f6085d80-d6b6-45cf-a42d-1d58e6d9452e

📥 Commits

Reviewing files that changed from the base of the PR and between 25f275d and a305d6e.

📒 Files selected for processing (5)

packages/i18n/locales/es/app.json
packages/i18n/locales/fr/app.json
packages/i18n/locales/ko/app.json
packages/i18n/locales/zh-CN/app.json
packages/i18n/locales/zh-TW/app.json

🚧 Files skipped from review as they are similar to previous changes (5)

packages/i18n/locales/ko/app.json
packages/i18n/locales/fr/app.json
packages/i18n/locales/zh-TW/app.json
packages/i18n/locales/es/app.json
packages/i18n/locales/zh-CN/app.json

📝 Walkthrough

Walkthrough

This PR aligns engine and dashboard tests with updated runtime contracts, expands duplicate-resolution coverage, replaces fixed worktree paths with temporary filesystem roots, and adds replanning and mobile-navigation translations for five locales.

Changes

Test contract alignment

Layer / File(s)	Summary
Runtime and validation test contracts `packages/dashboard/app/hooks/__tests__/`, `packages/engine/src/__tests__/executor-assigned-agent-runtime-config.test.ts`, `packages/engine/src/__tests__/mcp-pr-response-forwarding.test.ts`, `packages/engine/src/__tests__/pi-layers-wiring.test.ts`, `packages/engine/src/__tests__/reliability-interactions/`	Test mocks and assertions now match current constant extraction, runtime APIs, validation result shapes, and validator-run arguments.
Duplicate resolution coverage `packages/engine/src/__tests__/triage-*`	Tests cover explicit delete configuration and default prompt handling, including activity, metadata, pause, and lineage assertions.

Worktree test environments

Layer / File(s)	Summary
Backend worktree test environments `packages/engine/src/__tests__/worktree-acquisition-backend.test.ts`	Backend tests use temporary roots and updated command, filesystem, fallback, audit, and backend-argument expectations.
Worktrunk worktree test environments `packages/engine/src/__tests__/worktree-acquisition-worktrunk.test.ts`	Worktrunk tests use temporary roots, real filesystem operations, dynamic paths, and updated command working-directory assertions.

Localized UI strings

Layer / File(s)	Summary
Localized replanning and navigation strings `packages/i18n/locales/{es,fr,ko,zh-CN,zh-TW}/app.json`	Locales add replanning status labels and mobile-navigation settings text and actions.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Runfusion/Fusion#1874: Related worktree-acquisition test updates for Git command sequencing and start-point behavior.
Runfusion/Fusion#1910: Related mission-validation flow and validator-run argument updates.
Runfusion/Fusion#1919: Related mission-validation test updates involving validation results and mocked store methods.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the PR’s goal of restoring suite green after upstream drift, even if it is broad.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/main-tests-v3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps · 2026-07-17T18:48:01Z

Greptile Summary

This PR updates drifted tests and localization data to match current product behavior. The main changes are:

Align duplicate-resolution tests with prompt and opt-in delete modes.
Update mission validation, assigned-agent, MCP, and model-runtime test fixtures.
Exercise worktree path reservations with isolated temporary roots.
Point blocker retry coverage at the extracted constants module.
Add replan and mobile navigation translations in five locales.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues were found in the updated code.
The test fixtures now match the current product contracts.
Temporary worktree state is isolated and cleaned up after each test.

Important Files Changed

Filename	Overview
packages/engine/src/tests/worktree-acquisition-backend.test.ts	Uses isolated temporary roots and real filesystem operations for path-reservation coverage.
packages/engine/src/tests/worktree-acquisition-worktrunk.test.ts	Updates Worktrunk acquisition tests to use isolated temporary roots and probe-aware fixtures.
packages/engine/src/tests/triage-finalize-duplicate-lineage.test.ts	Covers default prompt handling and explicit opt-in deletion for duplicate markers.
packages/engine/src/tests/triage-split-into-subtasks-delete.test.ts	Updates duplicate deletion coverage with explicit settings and a live canonical task.
packages/engine/src/tests/reliability-interactions/mission-validation-trigger-gap.test.ts	Aligns validation mocks and expectations with the current result shape and task identifier.
packages/engine/src/tests/executor-assigned-agent-runtime-config.test.ts	Adds the async storage-layer fixture required for assigned-agent resolution.
packages/engine/src/tests/mcp-pr-response-forwarding.test.ts	Adds task lookup support to the MCP forwarding fixture.
packages/engine/src/tests/pi-layers-wiring.test.ts	Adds the model runtime initialization mock required by current Pi wiring.
packages/dashboard/app/hooks/tests/useBlockerFanout.test.ts	Reads the retry default from its extracted constants module.
packages/i18n/locales/es/app.json	Adds Spanish replan and mobile navigation translations.
packages/i18n/locales/fr/app.json	Adds French replan and mobile navigation translations.
packages/i18n/locales/ko/app.json	Adds Korean replan and mobile navigation translations.
packages/i18n/locales/zh-CN/app.json	Adds Simplified Chinese replan and mobile navigation translations.
packages/i18n/locales/zh-TW/app.json	Adds Traditional Chinese replan and mobile navigation translations.

_{Reviews (2): Last reviewed commit: "merge: origin/main into fix/main-tests-v..." | Re-trigger Greptile}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/engine/src/__tests__/triage-split-into-subtasks-delete.test.ts`:
- Around line 168-172: Update the getTask mock in the affected test to return
the canonical FN-4894 task for that ID while preserving the original default
current-task mock for all other IDs; do not return undefined for unmatched
lookups.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d9361725-945c-49d6-b0ed-1f04671bb569

📥 Commits

Reviewing files that changed from the base of the PR and between 065890c and 25f275d.

📒 Files selected for processing (14)

packages/dashboard/app/hooks/__tests__/useBlockerFanout.test.ts
packages/engine/src/__tests__/executor-assigned-agent-runtime-config.test.ts
packages/engine/src/__tests__/mcp-pr-response-forwarding.test.ts
packages/engine/src/__tests__/pi-layers-wiring.test.ts
packages/engine/src/__tests__/reliability-interactions/mission-validation-trigger-gap.test.ts
packages/engine/src/__tests__/triage-finalize-duplicate-lineage.test.ts
packages/engine/src/__tests__/triage-split-into-subtasks-delete.test.ts
packages/engine/src/__tests__/worktree-acquisition-backend.test.ts
packages/engine/src/__tests__/worktree-acquisition-worktrunk.test.ts
packages/i18n/locales/es/app.json
packages/i18n/locales/fr/app.json
packages/i18n/locales/ko/app.json
packages/i18n/locales/zh-CN/app.json
packages/i18n/locales/zh-TW/app.json

Resolve i18n locale conflicts by keeping translated Replan/mobile-nav strings and filling main's new add/select/remove nav keys for es/fr/ko/zh-CN/zh-TW.

gsxdsm · 2026-07-18T00:58:54Z

Follow-up for the resolved CodeRabbit thread on getTask mock fallback: #2283

## Summary Follow-up to #2275 review feedback: `getTask` mocks for DUPLICATE recovery tests now return a default current-task fixture for non-canonical IDs instead of `undefined`. ## Context CodeRabbit on #2275 noted that returning `undefined` for every id except the canonical task could break recovery if the subject task is re-fetched mid-path. ## Test plan - [x] `triage-split-into-subtasks-delete.test.ts` - [x] `triage-finalize-duplicate-lineage.test.ts`  ## Summary by CodeRabbit * **Tests** * Improved duplicate-resolution test coverage by preserving task data during recovery and re-fetch scenarios. * Added validation for non-canonical task handling to prevent errors when duplicate tasks are resolved or split.

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread packages/engine/src/__tests__/triage-split-into-subtasks-delete.test.ts

merge: origin/main into fix/main-tests-v3

a305d6e

Resolve i18n locale conflicts by keeping translated Replan/mobile-nav strings and filling main's new add/select/remove nav keys for es/fr/ko/zh-CN/zh-TW.

gsxdsm merged commit 3fcab9f into main Jul 18, 2026
7 checks passed

gsxdsm deleted the fix/main-tests-v3 branch July 18, 2026 00:27

gsxdsm mentioned this pull request Jul 18, 2026

test: preserve default getTask mock for DUPLICATE recovery #2283

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: green full-suite after main product drift#2275

fix: green full-suite after main product drift#2275
gsxdsm merged 2 commits into
mainfrom
fix/main-tests-v3

gsxdsm commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

greptile-apps Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

gsxdsm commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

gsxdsm commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

greptile-apps Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gsxdsm commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gsxdsm commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

greptile-apps Bot commented Jul 17, 2026 •

edited

Loading