Skip to content

fix: resolve claude-runtime probe source for CLI full-suite#2292

Merged
gsxdsm merged 2 commits into
mainfrom
fix/main-tests-v10
Jul 18, 2026
Merged

fix: resolve claude-runtime probe source for CLI full-suite#2292
gsxdsm merged 2 commits into
mainfrom
fix/main-tests-v10

Conversation

@gsxdsm

@gsxdsm gsxdsm commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Full Suite after #2291: shards 1–3 green; shard 4 failed CLI suites with:

Failed to resolve entry for package "@fusion-plugin-examples/claude-runtime"

from dashboard/src/runtime-provider-probes.ts under the CLI vitest package lane.

  • Add plugins/fusion-plugin-claude-runtime/src/probes-entry.ts (probe + model discovery only)
  • Alias @fusion-plugin-examples/claude-runtime to that entry in CLI vitest config (same class as Cursor/Grok/OMP source aliases, but avoids ACP index load)

Test plan

  • Local: vitest-workspace-resolution, task-steer, extension-task-tools
  • PR gate
  • Post-merge Full Suite green

Summary by CodeRabbit

  • Bug Fixes
    • Improved CLI resolution for Claude runtime diagnostics and provider model discovery.
    • Prevented unnecessary runtime dependencies from affecting CLI test execution.
  • Refactor
    • Added a lightweight entry point for accessing Claude binary checks and provider model discovery.

Full-suite shard 4 failed CLI suites importing dashboard runtime-provider-
probes when Vite resolved @fusion-plugin-examples/claude-runtime to dist/ and
the full ACP graph. Alias CLI tests to a thin probes-entry source module.
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cbddbe52-7ebc-4d5c-8120-e12a0a71f41e

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd9ccd and 4abd939.

📒 Files selected for processing (2)
  • packages/cli/vitest.config.ts
  • plugins/fusion-plugin-claude-runtime/src/probes-entry.ts

📝 Walkthrough

Walkthrough

Adds a thin Claude runtime probe entrypoint and updates CLI Vitest aliases to resolve the probe and package imports to source modules, avoiding full plugin-index resolution.

Changes

Claude runtime probe resolution

Layer / File(s) Summary
Probe entrypoint and CLI aliases
plugins/fusion-plugin-claude-runtime/src/probes-entry.ts, packages/cli/vitest.config.ts
The new entrypoint re-exports Claude binary probing and provider-model discovery APIs, while CLI Vitest aliases route the probe and package imports to source modules.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing CLI full-suite probe resolution for claude-runtime.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/main-tests-v10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes Claude runtime probe resolution in the CLI test suite. The main changes are:

  • Adds exact CLI Vitest aliases for the Claude runtime package and probe subpath.
  • Adds a lightweight entry point for binary probing and model discovery.
  • Avoids loading the ACP runtime dependency chain in CLI tests.

Confidence Score: 5/5

This looks safe to merge.

  • The lightweight entry exports every symbol required by the redirected consumer.
  • Its import chain does not load the ACP SDK or runtime adapter.
  • No blocking issue was found in the changed code.

Important Files Changed

Filename Overview
packages/cli/vitest.config.ts Adds exact source aliases for the Claude runtime package root and probe subpath.
plugins/fusion-plugin-claude-runtime/src/probes-entry.ts Exports the probe and model-discovery surface without importing the ACP runtime adapter.

Reviews (2): Last reviewed commit: "fix: export ClaudeBinaryStatus from prob..." | Re-trigger Greptile

@gsxdsm
gsxdsm merged commit 90e8a10 into main Jul 18, 2026
6 checks passed
@gsxdsm
gsxdsm deleted the fix/main-tests-v10 branch July 18, 2026 09:25
gsxdsm added a commit that referenced this pull request Jul 18, 2026
## Summary
Full Suite after #2292: shards 1–3 green; shard 4 failed FN-7537 backup
automation tests with `store.getGlobalSettingsDir is not a function`.

- Add `getGlobalSettingsDir` to routes-automation mock store
- Point backup-parity fixtures’ global dir at the temp fusion dir
- Dashboard Vitest: alias `@fusion-plugin-examples/claude-runtime` →
`probes-entry` (same class as CLI #2292)

## Test plan
- [x] Local manual backup run parity (4 tests)
- [ ] PR gate
- [ ] Post-merge Full Suite

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved automation backup test coverage for global backup directory
handling.
* Preserved reliable manual backup behavior and event ordering across
supported automation steps.
* Fixed dashboard API test configuration for Claude runtime probe
resolution.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant