fixed the invalid scancode transmute

[Rismosch]

removed an invalid transmute, that causes a panic in rustc v.1.90.0

related issue: #1501

[jagprog5]

@Cobrand @antonilol looks good to me. same form of fix as my previous one here.

[iddm]

Hey guys! I would be so glad if you could release a 0.38.1 containing the fix!

[antonilol]

Hey guys! I would be so glad if you could release a 0.38.1 containing the fix!

Should be possible, but the build is currently broken on windows (and mac maybe) (see #1511), so this would have to be backported on 0.38.0 to prevent including the breaking changes on crates.io (if it isn't broken there already, don't know exactly what caused it).

@Cobrand would have to release it, I am not an owner on crates.io.

[antonilol]

@iddm Note that a crate does not have to be on crates.io (only when publishing there). You can add dependencies from any git repo to Cargo.toml, see https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories.

[iddm]

Yes, this is what I am doing now, but I prefer to depend on semversioned crates to have expected and reliable outcome when upgrading. Depending on a revision/tag/branch/hash means you solve it right now but everything else must be carefully looked for, while when you update a dependency from 0.38.0 to 0.38.1 you know nothing had changed except for one or more bug fixes.

By the way, I suggest releasing a 1.0 as well, as sdl2 is in the maintenance mode now and nothing will be added to it anyway, so if this crate is almost there, I think we can go with 1.0.

[Cobrand]

I will branch from 0.38 and add this fix this week as 0.38.1, maybe a few others fixes as well if they are important as well (I haven't checked in a while).

[iddm]

I will branch from 0.38 and add this fix this week as 0.38.1, maybe a few others fixes as well if they are important as well (I haven't checked in a while).

Thanks! This one and the one with the controller reopen crash would be nice. But the latter, I guess, can't be cherry-picked that easy as it requires the fix from the C part of sdl, right?