feat(sdk-review): batch 4/6 — structural checks + BREAKING family#205
Merged
Conversation
1284315 to
2ca08b4
Compare
5afd4f7 to
ab90a3c
Compare
2ca08b4 to
597305e
Compare
ab90a3c to
aa08669
Compare
597305e to
9cf9da1
Compare
582b50f to
869b41d
Compare
Adds 5 checks that enforce structural conventions: ## Checks (.claude/scripts/) - check-docs.sh — DC-01..16 (user-guide.md sections; BTP dependency documentation for Destination/Fragments/Certificates/Regional Availability) - check-bdd.sh — BDD-01..05 (feature files + cross-language parity via module-aliases.yaml) - check-patterns.sh — PT-01..11 (factory pattern, py.typed, exception hierarchy, type hints). Scope-gated to client modules. - check-versioning.sh — VER-01..07 + BREAKING-01..04 family. Uses breaking-detector.py (from batch 1) for AST-based diff. BREAKING-01/02 BLOCK_LOCKED — cannot be suppressed. - check-commits.sh — COM-01 Conventional Commits. Merge commits skipped via parent-count detection (robust regardless of message shape). Part 4 of 6. Ref: AFSDK-3937
- check-commits/check-versioning: resolve BASE_SHA from origin/${GITHUB_BASE_REF}
merge-base rather than HEAD~10 (which fails on branches with <10 commits)
- check-versioning: set -e enabled; \s+ → [[:space:]]+ in version regex;
BREAKING checkbox accepts *, +, or - bullets and case-insensitive label
- check-bdd: alias YAML parser handles indented values and single-quoted
scalars; BDD-01 new-module detection walks diff blocks (new file mode +
next +++ b/…) instead of matching them on the same line
- check-docs: DC-12/13/14 use word-bounded SAP-namespaced references so
DocumentFragment, AWSRegion, and 'region_id' in docstrings no longer
trigger false positives
a025df1 to
46f1495
Compare
869b41d to
1a7ccc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds 5 checks:
check-docs(DC-01..16 including BTP dependency documentation),check-bdd(cross-language parity via aliases),check-patterns,check-versioning+ BREAKING-01..04 family (BLOCK_LOCKED, AST-based diff detection),check-commits(Conventional Commits with parent-count merge detection).This is part 4 of 6 in the incremental delivery of the SDK Module Review skill (AFSDK-3937).
Each sub-PR is scoped to be reviewable in ≤ 30 minutes and satisfies these isolation criteria:
Related Issue
Internal tracking: AFSDK-3937
Type of Change
How to Test
Batch progression
After all 6 batches are merged into
feat/sdk-review-skill, a final cosmetic PR will mergefeat/sdk-review-skillintomain.Checklist