Skip to content

Added SCEvents ability to create event#2070

Merged
maernest04 merged 8 commits intodevfrom
ernest_ma/SCEvents_add_create_event_form_2068
Apr 9, 2026
Merged

Added SCEvents ability to create event#2070
maernest04 merged 8 commits intodevfrom
ernest_ma/SCEvents_add_create_event_form_2068

Conversation

@maernest04
Copy link
Copy Markdown
Collaborator

@maernest04 maernest04 commented Apr 2, 2026

PR for issue 2068

Added Clark UI and wiring for SCEvents: officers and admins can open the events page and use a create event flow that talks to the SCEvents HTTP API. Submitted events are stored by SCEvents in its own MongoDB (scevents / events), not Clark’s main API database.

  • API client (src/APIFunctions/SCEvents.js): getSCEvents, createSCEvent, configurable base URL via - REACT_APP_SCEVENTS_URL (with a local dev fallback).
  • Pages: Events.js (listing + Create CTA for officers/admins), CreateEventPage.js + CreateEventFormQuestionBlock.js (form aligned with SCEvents event/registration payload shape).
  • Routing: Registered /events and /events/create in Routes.js with OFFICER_OR_ADMIN access for the create route.
  • Nav: Admin sidebar links for SCEvents and Create event when config.SCEvents.ENABLED is true (AdminNavbar.js).
  • Auth: Create-event access is officer or admin (consistent with other officer/admin tools), not admin-only.

Screenshots of what this would look like

Screenshot 2026-04-01 at 4 06 18 PM Screenshot 2026-04-01 at 4 06 21 PM Screenshot 2026-04-01 at 4 06 25 PM Screenshot 2026-04-03 at 12 02 25 AM

@steeevin88
Copy link
Copy Markdown
Collaborator

could we do a few things:

  1. link the issue that this resolves in the PR description (let's always do this in the future!)
  2. i merged Trista's PR that adds the page contents; can you fix the merge conflicts? we should be keeping her UI + just add your button somewhere (similar to what you did with the blank page)
  3. you mentioned the port conflicts + it makes sense; let's make the default port for SCEvents something else... i think we should make it 8002 (b/c SCEta is 8001, and Cleezy is 8000?). Can you double-check this, and then open a new PR in the SCEvents repo to change the default port? This means changing the default gin server setup to use port 8002 instead of the default, and changing the port mappings in the docker-compose as well. In the end, the server should run in its Docker container's port 8002, and we will map it to our local port 8002. lmk if this doesn't make sense

i'll give a closer review after these changes, but had a few questions from a brief look:

  • why is there an SCEvents tab in the admin page? and a separate Create Event one? if the SCEvents tab leads to the events page let's just remove it so we don't bloat the admin panel (if we need to navigate to it we can manually change the URL ourselves)
  • let's get rid of the base url logic and just assume it's the localhost port, i don't think we'll ever be doing the .env approach

Copy link
Copy Markdown
Collaborator

@steeevin88 steeevin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big pr so i will probably re-review 😅

Image

could we also increase the padding here?

Copy link
Copy Markdown
Collaborator

@steeevin88 steeevin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small comments but lgtm

please resolve all the comments once done + ping me again before we merge

Copy link
Copy Markdown
Collaborator

@steeevin88 steeevin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a reply on one of the above comments but otherwise lgtm 😄

please resolve all the other comments so this PR is less cluttered, we can merge after

@maernest04 maernest04 force-pushed the ernest_ma/SCEvents_add_create_event_form_2068 branch from 0bb8204 to 978ab53 Compare April 8, 2026 01:01
Copy link
Copy Markdown
Collaborator

@KhoaNguyen706 KhoaNguyen706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@steeevin88 steeevin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-reviewed

Copy link
Copy Markdown
Collaborator

@steeevin88 steeevin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@maernest04 maernest04 merged commit ea70088 into dev Apr 9, 2026
4 checks passed
@maernest04 maernest04 deleted the ernest_ma/SCEvents_add_create_event_form_2068 branch April 9, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants