Conversation
|
did you test this? could you include screenshots |
|
Yes, I did, It worked for mock data |
steeevin88
left a comment
steeevin88
left a comment
There was a problem hiding this comment.
left a few comments, in general though im confused why we have mock functions? as opposed to testing with actual Clark
i know it'll take a few extra steps to create the account in local Clark, create event, etc... but i'd prefer to be extra and ensure things work
also, i don't think any of this stuff is gated. remember that anything SCEvents related on Clark shouldn't be made public yet... so we need to ensure your new page is gated. (even though technically it's true that accessing this page is hard b/c you'd need access to the gated Events page... we should still be thorough)
|
|
||
| const SCEVENTS_API_URL = 'http://localhost:8002'; | ||
|
|
||
| // ======== ORIGINAL BACKEND API REQUESTS ======== |
|
|
||
| export const SceContext = createContext({ | ||
| user: {}, | ||
| setUser: () => {}, |
There was a problem hiding this comment.
is this change needed? if not please remove so we don't cherry pick
| setUser: () => {}, | ||
| setUser: () => { }, | ||
| authenticated: false, | ||
| setAuthenticated: () => {}, |
| } | ||
| // ========================================== | ||
|
|
||
| // ======== MOCKED VERSION FOR TESTING ======== |
There was a problem hiding this comment.
again im confused why we have a mock version; was there a reason why we didn't just use Clark locally?
| return ( | ||
| <div className="m-10 max-w-4xl px-4 sm:px-6"> | ||
| <div className="mb-8 pt-8 pb-2"> | ||
| <Link to="/events" className="block pb-3 text-sm link link-primary"> |
There was a problem hiding this comment.
hmm... this probably doesn't belong in this PR but it's fine
2 participants
I changed these:
Under construction...............